Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

feat(bericht): the PDF is A4-only, with column widths tuned to hardcoded German headers

Aperta
  • Qualcosa non va?
#404 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
40/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
csharp
Ambito
desktop, documentation

Direzione di ricerca

Start with IncidentReportDocument.cs and AttachmentCaptionSection.cs to trace where A4 is selected, then read RolesSection.cs for the seven column widths and German headings. Check IncidentSettings for where a paper-size choice could live, and Formatting.cs for the shared date format; the issue also references #350 for UI string mechanisms. Done means supporting A4/Letter and fitting column widths to measured header text, while accounting for the report’s German strings.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement i18n

From a portability review of main (ecb341b). Small and mechanical; grouped here because both halves live in LageBuch.Documents.

A4 is hardcoded

src/LageBuch.Documents/IncidentReportDocument.cs:56   page.Size(PageSizes.A4);
src/LageBuch.Documents/Sections/AttachmentCaptionSection.cs:32   page.Size(PageSizes.A4);

Margins are 1.5f, Unit.Centimetre. There is no Letter path and no setting. RolesSection.cs sizes its seven columns explicitly against "A4 portrait", so the page size is not purely a container — the column widths are tuned to it.

The section and column headings are hardcoded German arrays

e.g. RolesSection.cs:10 — ["Funktion", "Name", "Abschnitt", "Funkrufname", "Handynummer", "Von", "Bis"], plus "Einsatzdokumentation", "Einsatztagebuch (ETB)", "Kräfteübersicht", "Atemschutzüberwachung", "CO-Messprotokoll", "Angehängte Dateien", "Gesamtstärke: ", and the footer "Seite {n} / {total}". Roughly 42 distinct German literals across the assembly.

The PDF is also where the one de-DE CultureInfo in the codebase surfaces — Formatting.Timestamp (Formatting.cs:9,11, dd.MM.yyyy HH:mm) is shared by the report and the UI.

Why file it separately from #350

#350 is about the mechanism for UI strings. The report has two things the UI does not: column widths that are coupled to the chosen strings and the chosen page size, and an output that leaves the machine and gets filed. Whatever #350 decides, someone still has to re-fit RolesSection's seven columns when the headers change length — that work is specific to this assembly and worth knowing about before the i18n approach is chosen, not after.

Concretely: a paper-size setting (A4/Letter) on IncidentSettings, and the column widths derived from measured header text rather than tuned constants.

Lingua principale
C#
Stelle
1
Fork
3
Merge medio
4h 34m
PR unite (30g)
182

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di CodeForFire/lagebuch

Tutte le issue di CodeForFire/lagebuch

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.