feat(rückmeldung): "ILS" is hardcoded — including in the ETB entry written to the incident file
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- csharp, sqlite
- Domain
- backend-api-design, database
Research direction
Read #350 first to understand the project’s decision about persisted German wording. The issue identifies IncidentWorkspaceView.axaml:170, MasterDataEditorView.axaml:74,80, ReminderViewModel.cs:121, IncidentSettings, and etb_entries; trace how settings and ETB entries are stored and displayed. Done means the dispatch label is configurable in both labels and ETB records, consistent with the decision for old and new files.
Written by the indexing model from the issue text.
Description
From a portability review of main (ecb341b).
The gap
"ILS" — Integrierte Leitstelle — is the Bavarian name for the dispatch centre. Elsewhere in Germany the counterpart is a Kreisleitstelle, Rettungsleitstelle or plain Leitstelle; in Austria it is a Landeswarnzentrale or Bezirksalarmzentrale. The word is hardcoded in three places:
- the workspace button —
src/LageBuch.App.Shared/Views/IncidentWorkspaceView.axaml:170 - the two settings labels —
src/LageBuch.App.Shared/Views/MasterDataEditorView.axaml:74,80 - the ETB entry written into the incident file —
src/LageBuch.AppLogic/ViewModels/ReminderViewModel.cs:121:
EtbDirection.Outgoing, "Rückmeldung an ILS", from: _session.Operator?.CallSign, to: "ILS");
The first two are labels. The third is data: it lands in etb_entries.text and etb_entries.to and stays there for the life of the file.
Why this one is worth thinking about rather than just renaming
Everything else a brigade would recognise as local vocabulary is already master data — roles, vehicle status, Trupp types, call signs, checklists. StammdatenCatalogue never rejects an unknown value. The dispatch counterparty is the one operational concept the app names for you.
A string in IncidentSettings (md_settings, alongside ils_reminder_interval_minutes) covers the two labels cheaply. The ETB entry is the interesting half, because writing the configured label into the file makes the record locally correct but the file no longer self-describing, while writing a stable key and rendering the label at display time means old files and new files disagree about what they contain.
That is the same question #350 has to answer for every other piece of German wording the domain persists, so this issue should probably wait on that decision rather than pre-empt it — but the dispatch label is a good concrete test case for whatever gets decided, because unlike "Einsatz begonnen" it genuinely varies between installs within Germany.
Scope note
The ils_number column in incident_meta is unrelated legacy — a retired second number merged back into the Einsatznummer on load (IncidentRepository.cs:633-639). Not part of this.
- Dominant language
- C#
- Stars
- 1
- Forks
- 3
- Avg merge
- 4h 15m
- Merged PRs (30d)
- 181
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CodeForFire/lagebuch
-
Stammdaten: in the Checkliste editor the PFLICHT header is not aligned with its columnPossibly taken @Saad-elnagar claimed this 2 days ago. Openbug ux
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
CodeForFire/lagebuch#714 · 1 comment ·
Maintainers usually reply within 1 day
-
Stammdaten: on a phone the Fahrzeuge editor squeezes Wache and Funkrufname to nothingPossibly taken @Saad-elnagar claimed this 2 days ago. Openbug ux
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
CodeForFire/lagebuch#713 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
CodeForFire/lagebuch#405 ·
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
CodeForFire/lagebuch#349 ·
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
CodeForFire/lagebuch#348 ·
Maintainers usually reply within 1 day
All issues in CodeForFire/lagebuch
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Nimblesite/SharpLsp#468 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
elastic/ecs-dotnet#575 ·
-
alerts bug effort:S P2
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
nightscout/nocturne#2511 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 2 days
-
Crash in v3.00Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
arkane-systems/mousejiggler#140 ·