feat(rückmeldung): "ILS" is hardcoded — including in the ETB entry written to the incident file
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Aptitud para principiantes
- 35/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bastante claro
- Estado de actividad
- Activo
- Stack tecnológico
- csharp, sqlite
- Área
- backend-api-design, database
Línea de trabajo
Read #350 first to understand the project’s decision about persisted German wording. The issue identifies IncidentWorkspaceView.axaml:170, MasterDataEditorView.axaml:74,80, ReminderViewModel.cs:121, IncidentSettings, and etb_entries; trace how settings and ETB entries are stored and displayed. Done means the dispatch label is configurable in both labels and ETB records, consistent with the decision for old and new files.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
From a portability review of main (ecb341b).
The gap
"ILS" — Integrierte Leitstelle — is the Bavarian name for the dispatch centre. Elsewhere in Germany the counterpart is a Kreisleitstelle, Rettungsleitstelle or plain Leitstelle; in Austria it is a Landeswarnzentrale or Bezirksalarmzentrale. The word is hardcoded in three places:
- the workspace button —
src/LageBuch.App.Shared/Views/IncidentWorkspaceView.axaml:170 - the two settings labels —
src/LageBuch.App.Shared/Views/MasterDataEditorView.axaml:74,80 - the ETB entry written into the incident file —
src/LageBuch.AppLogic/ViewModels/ReminderViewModel.cs:121:
EtbDirection.Outgoing, "Rückmeldung an ILS", from: _session.Operator?.CallSign, to: "ILS");
The first two are labels. The third is data: it lands in etb_entries.text and etb_entries.to and stays there for the life of the file.
Why this one is worth thinking about rather than just renaming
Everything else a brigade would recognise as local vocabulary is already master data — roles, vehicle status, Trupp types, call signs, checklists. StammdatenCatalogue never rejects an unknown value. The dispatch counterparty is the one operational concept the app names for you.
A string in IncidentSettings (md_settings, alongside ils_reminder_interval_minutes) covers the two labels cheaply. The ETB entry is the interesting half, because writing the configured label into the file makes the record locally correct but the file no longer self-describing, while writing a stable key and rendering the label at display time means old files and new files disagree about what they contain.
That is the same question #350 has to answer for every other piece of German wording the domain persists, so this issue should probably wait on that decision rather than pre-empt it — but the dispatch label is a good concrete test case for whatever gets decided, because unlike "Einsatz begonnen" it genuinely varies between installs within Germany.
Scope note
The ils_number column in incident_meta is unrelated legacy — a retired second number merged back into the Einsatznummer on load (IncidentRepository.cs:633-639). Not part of this.
- Lenguaje dominante
- C#
- Estrellas
- 1
- Forks
- 3
- Merge medio
- 4 h 34 min
- PR fusionados (30 d)
- 182
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de CodeForFire/lagebuch
-
bug ux
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
CodeForFire/lagebuch#714 ·
Los mantenedores suelen responder en 1 día
-
bug ux
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
CodeForFire/lagebuch#713 ·
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
CodeForFire/lagebuch#405 ·
Los mantenedores suelen responder en 1 día
-
documentation good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
CodeForFire/lagebuch#349 ·
Los mantenedores suelen responder en 1 día
-
documentation good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
CodeForFire/lagebuch#348 ·
Los mantenedores suelen responder en 1 día
Todos los issues de CodeForFire/lagebuch
Issues similares
-
/api/oauth/introspect emits clientId and tokenType instead of RFC 7662's client_id and token_typeAbiertobug P2
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
nightscout/nocturne#2317 ·
Los mantenedores suelen responder en 1 día
-
[BUG]: Position intent set on a simple order is dropped when it becomes a bracket, OCO or OTO orderPosiblemente ocupada @RaphaelFakhri la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
alpacahq/alpaca-trade-api-csharp#903 ·
Los mantenedores suelen responder en 2 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 64/100
joinrpg/joinrpg-net#5752 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
dimitar-radenkov/Pointframe#294 ·
Los mantenedores suelen responder en 1 día
-
kind/feature-request
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Altinn/altinn-correspondence#2154 ·
Los mantenedores suelen responder en 1 día