probe lint has no way to fail CI on warnings (--fail-on-warning covers agent warnings only)

Open
#466 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
go
Domain
cli, testing

Research direction

Start by locating the probe lint command, its warning reporting and exit-status logic, then read the CLI reference and CI guides named in the acceptance criteria. Check how probe validate and the MCP lint tool expose lint warnings. Done means lint keeps exit 0 by default, --strict exits 1 on warnings with the same output, and the specified docs and changelog are updated.

Written by the indexing model from the issue text.

Description

area/cli enhancement

What happens

probe lint reports warnings (since 0.26.0 this includes the unanchored count and zero-state text check, for example a see "250 ml" that also passes on "1250 ml") but exits 0 when it finds only warnings. A project with dozens of such warnings cannot make CI fail on new ones.

probe test --fail-on-warning does not help: its documented scope is agent warnings at run time (a tap that did nothing, press enter with no focus, go back at the root), and it does not look at lint results. The behaviour matches the docs; the gap is that no flag turns lint warnings into a failing exit status.

Found while running a real project's suite against 0.26.0-next.1: 30 lint warnings, exit status 0, and --fail-on-warning unchanged.

Proposal

  • Add probe lint --strict (or --fail-on-warning, same name as the test flag but documented for lint): exit non-zero when any warning is reported. Default unchanged.
  • Say in the CLI reference for probe test --fail-on-warning that it covers agent warnings only, and point to probe lint --strict for lint.
  • Optionally let probe test run the same check before the run (--lint-strict), so one command is enough in CI. Out of scope for the first change.

Acceptance

  • probe lint with warnings only: exit 0 (unchanged); with --strict: exit 1 and the same output.
  • probe validate and the MCP lint tool report the same warnings; the tool gains a strict option or says exit status is not applicable.
  • Docs: CLI reference (lint, test --fail-on-warning), the CI guides' lint step, CHANGELOG.
Dominant language
Go
Stars
6
Forks
3
Avg merge
6h 28m
Merged PRs (30d)
362

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from AlphaWaveSystems/flutter-probe

All issues in AlphaWaveSystems/flutter-probe

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.