create_or_update_file rejects explicitly empty file content

Open Beginner friendly
#3,883 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 4 days

@Elon-Jiang is already working on this.

Since Nov 18, 2026.

  • #3884 by @Elon-Jiang — open

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
github, go

Research direction

Start at CreateOrUpdateFile(...).Handler(...) and compare how it handles an explicitly empty content string with push_files; the issue reports two failing regression cases and passing nonempty create/update cases. Add coverage for empty content on create and update, while retaining rejection of absent or null content and the stated SHA and symlink protections. Done when those cases pass through the real go-github client without an early missing-content error.

Written by the indexing model from the issue text.

Description

Description

create_or_update_file rejects an explicitly supplied empty string with missing required parameter: content, preventing agents from creating empty package markers such as __init__.py / .gitkeep, or intentionally clearing an existing file.

The tool schema requires a string but does not impose a minimum length. The GitHub Contents API accepts empty base64 content, and push_files already distinguishes absent content from an explicitly empty string.

Reproduction

Call the tool with {"owner":"owner","repo":"repo","path":"__init__.py","branch":"main","message":"Add package marker","content":""}. Expected: a Contents API request with content: "". Actual: the tool returns an error before making any HTTP request. Updating an existing ordinary file with its current SHA fails in the same way.

Reproduced at 4e6e6c053e48aac182f7768162fef2ad42fe7d5f through CreateOrUpdateFile(...).Handler(...), using the real go-github REST client with a controlled HTTP transport. Two new regression cases fail; existing nonempty create/update cases pass. No live repository write was performed in reproduction.

I plan to allow explicitly empty content while continuing to reject absent/null content, preserving the existing exported Go input type, JSON schema, SHA validation and symlink protections. I checked the complete open PR file lists and relevant closed PRs; #3313 (binary encoding) and #2772 (GraphQL migration) retain the empty-string rejection and address different behavior.

This report and proposed fix were prepared with AI assistance.

Dominant language
Go
Stars
34.4k
Forks
5.3k
Avg merge
4d 12h
Merged PRs (30d)
13

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from github/github-mcp-server

All issues in github/github-mcp-server

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.