probe lint has no way to fail CI on warnings (--fail-on-warning covers agent warnings only)

未关闭
#466 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
go
领域
cli, testing

调研方向

Start by locating the probe lint command, its warning reporting and exit-status logic, then read the CLI reference and CI guides named in the acceptance criteria. Check how probe validate and the MCP lint tool expose lint warnings. Done means lint keeps exit 0 by default, --strict exits 1 on warnings with the same output, and the specified docs and changelog are updated.

由索引模型根据 Issue 内容生成。

描述

area/cli enhancement

What happens

probe lint reports warnings (since 0.26.0 this includes the unanchored count and zero-state text check, for example a see "250 ml" that also passes on "1250 ml") but exits 0 when it finds only warnings. A project with dozens of such warnings cannot make CI fail on new ones.

probe test --fail-on-warning does not help: its documented scope is agent warnings at run time (a tap that did nothing, press enter with no focus, go back at the root), and it does not look at lint results. The behaviour matches the docs; the gap is that no flag turns lint warnings into a failing exit status.

Found while running a real project's suite against 0.26.0-next.1: 30 lint warnings, exit status 0, and --fail-on-warning unchanged.

Proposal

  • Add probe lint --strict (or --fail-on-warning, same name as the test flag but documented for lint): exit non-zero when any warning is reported. Default unchanged.
  • Say in the CLI reference for probe test --fail-on-warning that it covers agent warnings only, and point to probe lint --strict for lint.
  • Optionally let probe test run the same check before the run (--lint-strict), so one command is enough in CI. Out of scope for the first change.

Acceptance

  • probe lint with warnings only: exit 0 (unchanged); with --strict: exit 1 and the same output.
  • probe validate and the MCP lint tool report the same warnings; the tool gains a strict option or says exit status is not applicable.
  • Docs: CLI reference (lint, test --fail-on-warning), the CI guides' lint step, CHANGELOG.
主要语言
Go
星标
6
派生
3
平均合并
6 小时 28 分钟
30 天内合并 PR
362

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

AlphaWaveSystems/flutter-probe 的其他 Issue

查看 AlphaWaveSystems/flutter-probe 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。