probe lint has no way to fail CI on warnings (--fail-on-warning covers agent warnings only)

Abierto
#466 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
48/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
go
Área
cli, testing

Línea de trabajo

Start by locating the probe lint command, its warning reporting and exit-status logic, then read the CLI reference and CI guides named in the acceptance criteria. Check how probe validate and the MCP lint tool expose lint warnings. Done means lint keeps exit 0 by default, --strict exits 1 on warnings with the same output, and the specified docs and changelog are updated.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area/cli enhancement

What happens

probe lint reports warnings (since 0.26.0 this includes the unanchored count and zero-state text check, for example a see "250 ml" that also passes on "1250 ml") but exits 0 when it finds only warnings. A project with dozens of such warnings cannot make CI fail on new ones.

probe test --fail-on-warning does not help: its documented scope is agent warnings at run time (a tap that did nothing, press enter with no focus, go back at the root), and it does not look at lint results. The behaviour matches the docs; the gap is that no flag turns lint warnings into a failing exit status.

Found while running a real project's suite against 0.26.0-next.1: 30 lint warnings, exit status 0, and --fail-on-warning unchanged.

Proposal

  • Add probe lint --strict (or --fail-on-warning, same name as the test flag but documented for lint): exit non-zero when any warning is reported. Default unchanged.
  • Say in the CLI reference for probe test --fail-on-warning that it covers agent warnings only, and point to probe lint --strict for lint.
  • Optionally let probe test run the same check before the run (--lint-strict), so one command is enough in CI. Out of scope for the first change.

Acceptance

  • probe lint with warnings only: exit 0 (unchanged); with --strict: exit 1 and the same output.
  • probe validate and the MCP lint tool report the same warnings; the tool gains a strict option or says exit status is not applicable.
  • Docs: CLI reference (lint, test --fail-on-warning), the CI guides' lint step, CHANGELOG.
Lenguaje dominante
Go
Estrellas
6
Forks
3
Merge medio
6 h 28 min
PR fusionados (30 d)
362

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de AlphaWaveSystems/flutter-probe

Todos los issues de AlphaWaveSystems/flutter-probe

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.