bug: a database outage longer than ~30 seconds permanently stops cron schedules (self-hosted)

未关闭
  • 哪里不对？
#5,120 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

  • #5128 来自 @umeraamir69 —— 已关闭，未合并

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
docker-compose, postgresql, redis, typescript
领域
backend

调研方向

Start with the retry budget in internal-packages/schedule-engine/src/engine/workerCatalog.ts and the finalAttempt TODO in internal-packages/schedule-engine/src/engine/index.ts, then follow ScheduleEngine.triggerScheduledTask to registerNextTaskScheduleInstance. Look at recoverSchedulesInEnvironment as the existing reconciliation logic. Done means a schedule survives a database outage of about 75 seconds in a four-schedule test and keeps firing afterwards, with no duplicate runs. The fix direction is a maintainer decision, so check the thread before starting.

由索引模型根据 Issue 内容生成。

描述

Provide environment information
  • Self-hosted Trigger.dev v4.8.3 (Docker Compose), linux/arm64
  • External PostgreSQL reached through a TCP proxy, Redis 7
  • The same code is in v4.8.5 and on main as of 2026-11-12
Describe the bug

A short PostgreSQL outage permanently stops cron schedules. Ours lasted about 35 seconds and stopped 8 of 123 active schedules. They never fired again until we called the admin recover endpoint (/admin/api/v1/environments/{id}/schedules/recover). Nothing in the dashboard shows that a schedule has stopped.

Why it happens:

  1. Each tick is one schedule-engine worker job, schedule.triggerScheduledTask. The next tick is only registered at the end of a successful handler (ScheduleEngine.triggerScheduledTask → registerNextTaskScheduleInstance).
  2. scheduleWorkerCatalog gives that job retry: { maxAttempts: 5 } (internal-packages/schedule-engine/src/engine/workerCatalog.ts). With the redis-worker defaults (factor 2, 1 s base, randomized) all five attempts finish in about 15–30 seconds.
  3. If PostgreSQL is unreachable for that whole window, the job goes to the dead-letter queue. No job exists for the instance any more, so nothing registers the next tick. The chain is broken for good.
  4. The handler is called with finalAttempt: false, // TODO: implement retry logic (internal-packages/schedule-engine/src/engine/index.ts), so there is no last-attempt fallback.
Reproduction repo

No repo needed; this reproduces on a stock self-hosted install.

To reproduce
  1. Self-host v4.8.3 with a few * * * * * schedules in a production environment.
  2. Stop PostgreSQL for about 75 seconds, starting just before a minute boundary. Then start it again.
  3. Check Redis. Most schedules now have no entry in schedule:schedule:{queue:schedule-engine-worker:}items and one in …dlq. They never fire again.

In an isolated test with four schedules, three stopped permanently after a 76 second outage.

Suggested fix
  • Reconcile periodically. Run the existing recoverSchedulesInEnvironment logic on a timer for all active, non-development instances, using enqueueOnce so a live job is never replaced. This makes the chain self-healing whatever the cause. We run a 60 second loop as a local patch; with it, a 12 minute outage recovered six seconds after PostgreSQL returned, with no duplicate runs.
  • A longer retry budget for this job, for example maxAttempts: 15 with maxTimeoutInMs: 60_000 (about 9–10 minutes). A short outage then costs a late tick instead of a lost schedule. calculateNextSchedulableOccurrence already skips expired slots, so there is no backlog replay.
  • An idempotency key on the scheduled trigger (instance id + schedule time). Today a retry after "trigger succeeded, next-tick registration failed" can trigger the same slot twice, and a longer retry budget makes that more likely.
  • Make it visible. A metric or dashboard state for "active schedule with no pending job" would surface this.
Additional information

The webapp log at the time showed Failed to trigger scheduled task and then Failed to register schedule instance, both with Prisma Can't reach database server, for each affected instance. The dead-letter entries carry the same error with attempt: 4.

主要语言
TypeScript
星标
16.5k
派生
1.5k
平均合并
1 天 15 小时
30 天内合并 PR
17

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

triggerdotdev/trigger.dev 的其他 Issue

查看 triggerdotdev/trigger.dev 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。