bug: a database outage longer than ~30 seconds permanently stops cron schedules (self-hosted)

Đang mở
  • Có gì không ổn?
#5,120 2 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

  • #5128 của @umeraamir69 — đã đóng, không merge

Đánh giá

Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức phù hợp với người mới
35/100
Loại issue
Lỗi
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
docker-compose, postgresql, redis, typescript
Lĩnh vực
backend

Hướng nghiên cứu

Start with the retry budget in internal-packages/schedule-engine/src/engine/workerCatalog.ts and the finalAttempt TODO in internal-packages/schedule-engine/src/engine/index.ts, then follow ScheduleEngine.triggerScheduledTask to registerNextTaskScheduleInstance. Look at recoverSchedulesInEnvironment as the existing reconciliation logic. Done means a schedule survives a database outage of about 75 seconds in a four-schedule test and keeps firing afterwards, with no duplicate runs. The fix direction is a maintainer decision, so check the thread before starting.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Provide environment information
  • Self-hosted Trigger.dev v4.8.3 (Docker Compose), linux/arm64
  • External PostgreSQL reached through a TCP proxy, Redis 7
  • The same code is in v4.8.5 and on main as of 2026-11-12
Describe the bug

A short PostgreSQL outage permanently stops cron schedules. Ours lasted about 35 seconds and stopped 8 of 123 active schedules. They never fired again until we called the admin recover endpoint (/admin/api/v1/environments/{id}/schedules/recover). Nothing in the dashboard shows that a schedule has stopped.

Why it happens:

  1. Each tick is one schedule-engine worker job, schedule.triggerScheduledTask. The next tick is only registered at the end of a successful handler (ScheduleEngine.triggerScheduledTask → registerNextTaskScheduleInstance).
  2. scheduleWorkerCatalog gives that job retry: { maxAttempts: 5 } (internal-packages/schedule-engine/src/engine/workerCatalog.ts). With the redis-worker defaults (factor 2, 1 s base, randomized) all five attempts finish in about 15–30 seconds.
  3. If PostgreSQL is unreachable for that whole window, the job goes to the dead-letter queue. No job exists for the instance any more, so nothing registers the next tick. The chain is broken for good.
  4. The handler is called with finalAttempt: false, // TODO: implement retry logic (internal-packages/schedule-engine/src/engine/index.ts), so there is no last-attempt fallback.
Reproduction repo

No repo needed; this reproduces on a stock self-hosted install.

To reproduce
  1. Self-host v4.8.3 with a few * * * * * schedules in a production environment.
  2. Stop PostgreSQL for about 75 seconds, starting just before a minute boundary. Then start it again.
  3. Check Redis. Most schedules now have no entry in schedule:schedule:{queue:schedule-engine-worker:}items and one in …dlq. They never fire again.

In an isolated test with four schedules, three stopped permanently after a 76 second outage.

Suggested fix
  • Reconcile periodically. Run the existing recoverSchedulesInEnvironment logic on a timer for all active, non-development instances, using enqueueOnce so a live job is never replaced. This makes the chain self-healing whatever the cause. We run a 60 second loop as a local patch; with it, a 12 minute outage recovered six seconds after PostgreSQL returned, with no duplicate runs.
  • A longer retry budget for this job, for example maxAttempts: 15 with maxTimeoutInMs: 60_000 (about 9–10 minutes). A short outage then costs a late tick instead of a lost schedule. calculateNextSchedulableOccurrence already skips expired slots, so there is no backlog replay.
  • An idempotency key on the scheduled trigger (instance id + schedule time). Today a retry after "trigger succeeded, next-tick registration failed" can trigger the same slot twice, and a longer retry budget makes that more likely.
  • Make it visible. A metric or dashboard state for "active schedule with no pending job" would surface this.
Additional information

The webapp log at the time showed Failed to trigger scheduled task and then Failed to register schedule instance, both with Prisma Can't reach database server, for each affected instance. The dead-letter entries carry the same error with attempt: 4.

Ngôn ngữ chính
TypeScript
Star
16.5k
Fork
1.5k
Merge trung bình
1 ngày 15 giờ
Pull request đã merge (30 ngày)
17

Chuẩn bị môi trường

Dự án này không cung cấp dev container, Dockerfile hay hướng dẫn đóng góp, nên bạn cần tự thiết lập môi trường: hãy bắt đầu từ README và xem hướng dẫn đóng góp lần đầu của chúng tôi để biết các bước chung.

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của triggerdotdev/trigger.dev

Tất cả issue của triggerdotdev/trigger.dev

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.