bug: a database outage longer than ~30 seconds permanently stops cron schedules (self-hosted)

未關閉
  • 哪裡不對？
#5,120 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

  • #5128 來自 @umeraamir69 —— 已關閉，未合併

評估

難度
4/5
預估耗時
3-5 天
新手友好度
35/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
docker-compose, postgresql, redis, typescript
領域
backend

研究方向

Start with the retry budget in internal-packages/schedule-engine/src/engine/workerCatalog.ts and the finalAttempt TODO in internal-packages/schedule-engine/src/engine/index.ts, then follow ScheduleEngine.triggerScheduledTask to registerNextTaskScheduleInstance. Look at recoverSchedulesInEnvironment as the existing reconciliation logic. Done means a schedule survives a database outage of about 75 seconds in a four-schedule test and keeps firing afterwards, with no duplicate runs. The fix direction is a maintainer decision, so check the thread before starting.

由索引模型根據 Issue 內容生成。

描述

Provide environment information
  • Self-hosted Trigger.dev v4.8.3 (Docker Compose), linux/arm64
  • External PostgreSQL reached through a TCP proxy, Redis 7
  • The same code is in v4.8.5 and on main as of 2026-11-12
Describe the bug

A short PostgreSQL outage permanently stops cron schedules. Ours lasted about 35 seconds and stopped 8 of 123 active schedules. They never fired again until we called the admin recover endpoint (/admin/api/v1/environments/{id}/schedules/recover). Nothing in the dashboard shows that a schedule has stopped.

Why it happens:

  1. Each tick is one schedule-engine worker job, schedule.triggerScheduledTask. The next tick is only registered at the end of a successful handler (ScheduleEngine.triggerScheduledTask → registerNextTaskScheduleInstance).
  2. scheduleWorkerCatalog gives that job retry: { maxAttempts: 5 } (internal-packages/schedule-engine/src/engine/workerCatalog.ts). With the redis-worker defaults (factor 2, 1 s base, randomized) all five attempts finish in about 15–30 seconds.
  3. If PostgreSQL is unreachable for that whole window, the job goes to the dead-letter queue. No job exists for the instance any more, so nothing registers the next tick. The chain is broken for good.
  4. The handler is called with finalAttempt: false, // TODO: implement retry logic (internal-packages/schedule-engine/src/engine/index.ts), so there is no last-attempt fallback.
Reproduction repo

No repo needed; this reproduces on a stock self-hosted install.

To reproduce
  1. Self-host v4.8.3 with a few * * * * * schedules in a production environment.
  2. Stop PostgreSQL for about 75 seconds, starting just before a minute boundary. Then start it again.
  3. Check Redis. Most schedules now have no entry in schedule:schedule:{queue:schedule-engine-worker:}items and one in …dlq. They never fire again.

In an isolated test with four schedules, three stopped permanently after a 76 second outage.

Suggested fix
  • Reconcile periodically. Run the existing recoverSchedulesInEnvironment logic on a timer for all active, non-development instances, using enqueueOnce so a live job is never replaced. This makes the chain self-healing whatever the cause. We run a 60 second loop as a local patch; with it, a 12 minute outage recovered six seconds after PostgreSQL returned, with no duplicate runs.
  • A longer retry budget for this job, for example maxAttempts: 15 with maxTimeoutInMs: 60_000 (about 9–10 minutes). A short outage then costs a late tick instead of a lost schedule. calculateNextSchedulableOccurrence already skips expired slots, so there is no backlog replay.
  • An idempotency key on the scheduled trigger (instance id + schedule time). Today a retry after "trigger succeeded, next-tick registration failed" can trigger the same slot twice, and a longer retry budget makes that more likely.
  • Make it visible. A metric or dashboard state for "active schedule with no pending job" would surface this.
Additional information

The webapp log at the time showed Failed to trigger scheduled task and then Failed to register schedule instance, both with Prisma Can't reach database server, for each affected instance. The dead-letter entries carry the same error with attempt: 4.

主要語言
TypeScript
星號
16.5k
分支
1.5k
平均合併
1 天 15 小時
30 天內合併 PR
17

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

triggerdotdev/trigger.dev 的其他 Issue

查看 triggerdotdev/trigger.dev 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。