`query()` copies a `respond()` envelope's `Content-Type: application/json` onto the SSR document response
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 76/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- typescript
调研方向
Start in @solidjs/router/dist/data/query.js, around handleResponse at lines 248-263, and reproduce the issue with the provided Vite build and curl commands. Trace how respond() headers reach the SSR document response, then verify that envelope representation headers no longer replace text/html while needed redirect-related headers still work.
由索引模型根据 Issue 内容生成。
描述
Versions
- @solidjs/router 2.0.0-next.30 and 2.0.0-next.31
- @solidjs/web 2.0.0-rc.11, solid-js 2.0.0-rc.11
- @solidjs/vite-plugin 3.0.0-next.46 (start mode,
ssr: true,serverFunctions: true, defaultrenderMode) - vite 8.3.1, Node 24.20.0
Reproduction
// vite.config.ts
import { defineConfig } from 'vite'
import solid from '@solidjs/vite-plugin'
export default defineConfig({
plugins: [solid({ start: { node: true }, ssr: true, serverFunctions: true })]
})
// src/data.ts
import { respond } from '@solidjs/web'
export async function thrownRead(): Promise<never> {
'use server'
await new Promise(resolve => setTimeout(resolve, 20))
throw respond({ message: 'conflict' }, { status: 409 })
}
export async function returnedRead() {
'use server'
await new Promise(resolve => setTimeout(resolve, 20))
return respond({ message: 'accepted' }, { status: 202 })
}
// src/pages.tsx
import { createMemo } from 'solid-js'
import { query } from '@solidjs/router'
import { returnedRead, thrownRead } from './data'
const getThrown = query(thrownRead, 'thrown')
const getReturned = query(returnedRead, 'returned')
export function Thrown() {
const data = createMemo(() => getThrown())
return <p>{String(data())}</p>
}
export function Returned() {
const data = createMemo(() => getReturned())
return <p>{data().message}</p>
}
export function Home() {
return <p>home</p>
}
// src/router.ts
import { createRouter } from '@solidjs/router'
import { Home, Returned, Thrown } from './pages'
export const Router = createRouter({
routes: [
{ path: '/', component: Home },
{ path: '/thrown', component: Thrown },
{ path: '/returned', component: Returned }
]
})
// src/App.tsx
import { Errored } from 'solid-js'
import { httpStatus } from '@solidjs/web'
import { Router } from './router'
function Failed() {
httpStatus(500)
return <p>failed</p>
}
export default function App() {
return (
<Errored fallback={() => <Failed />}>
<Router>{props => props.children}</Router>
</Errored>
)
}
vite build
PORT=4399 node dist/server/node.js
curl -sS -D - -o /dev/null http://127.0.0.1:4399/
curl -sS -D - -o /dev/null http://127.0.0.1:4399/thrown
curl -sS -D - -o /dev/null http://127.0.0.1:4399/returned
Expected
Both documents keep content-type: text/html; charset=utf-8, like /. The envelope's Content-Type describes the envelope's own JSON body; it is not metadata for the page that read the query.
Actual
/ HTTP/1.1 200 OK content-type: text/html; charset=utf-8
/thrown HTTP/1.1 500 Internal Server Error content-type: application/json
/returned HTTP/1.1 200 OK content-type: application/json
The body of both is the HTML document, so browsers render it as text. The server also logs twice:
[LATE_HEADER_WRITE] Response header write dropped: headers.set("content-type") ran after the response head was sent. Write headers before the shell flushes (or before the handler returns).
Same result with router 2.0.0-next.31.
Analysis (published files)
respond()gives the carried ResponseContent-Type: application/json(@solidjs/web/dist/server.js,respond, line 520 in rc.11).- A server function called directly during SSR runs with a shallow copy of the page event, so
getRequestEvent().responseinside the read is the page's response stub (@solidjs/web/server-functions/dist/server.js, around lines 1469-1477 in rc.11). query()'shandleResponseunwraps the envelope and then copies every header ofenvelope.responseontogetRequestEvent().response(@solidjs/router/dist/data/query.js, lines 248-263 in next.30). For a returned or thrownrespond(), that includescontent-type.- Copies that run before the shell flush end up on the document; later reads hit the committed stub and are dropped with
[LATE_HEADER_WRITE].
The blanket header copy comes from #525 (for Set-Cookie on redirects). The envelope unwrap added in front of it later (c9f8c25a, "Adopt the core server-function protocol from @solidjs/web") now routes the envelope's body headers into it. The next branch at the 2.0.0-next.31 release still copies every header without a filter.
Possible fix
In handleResponse, skip representation headers (content-type, content-length, content-encoding, transfer-encoding) when copying from a Response or envelope onto e.response, and consider not writing to e.response once it is committed.
Related
- #525: introduced the header copy in
handleResponse. - #603 / #606: same
handleResponse, redirect carrier only; the header copy is unchanged. - solidjs/solid#3433: added the
[LATE_HEADER_WRITE]diagnostic. - solidjs/solid-start#2025: a different late header write through
query()+ redirect during SSR (closed as not planned).
- 主要语言
- TypeScript
- 星标
- 1.3k
- 派生
- 180
- 平均合并
- 1 天 11 分钟
- 30 天内合并 PR
- 34
环境准备
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
solidjs/solid-router 的其他 Issue
-
bug
难度 4/5 3-5 天 新手友好度 52/100
solidjs/solid-router#643 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 50/100
solidjs/solid-router#625 · 1 条评论 ·
维护者通常 1 天内回复
-
<A> costs ~6us of server CPU per instance during SSR (20x a plain <a>), mostly mergeProps/splitProps未关闭
难度 4/5 3-5 天 新手友好度 55/100
solidjs/solid-router#583 ·
维护者通常 1 天内回复
-
enhancement
难度 5/5 一周以上 新手友好度 35/100
solidjs/solid-router#569 · 3 条评论 ·
维护者通常 1 天内回复
-
enhancement
难度 3/5 1-2 天 新手友好度 38/100
solidjs/solid-router#518 · 2 条评论 ·
维护者通常 1 天内回复
查看 solidjs/solid-router 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 78/100
lichess-org/api#678 ·
-
难度 2/5 1-3 小时 新手友好度 84/100
PostHog/posthog.com#20628 ·
维护者通常 1 天内回复
-
bug status:Needs Triage
难度 1/5 1 小时以内 新手友好度 92/100
jupyterlab/jupyterlab#19964 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
agentscope-ai/QwenPaw#8064 · 1 条评论 ·
维护者通常 1 天内回复
-
area: notebooks-jupyter bug theme: new notebook frontend
难度 2/5 1-3 小时 新手友好度 88/100
posit-dev/positron#16347 · 1 条评论 ·
维护者通常 1 天内回复