Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

`query()` copies a `respond()` envelope's `Content-Type: application/json` onto the SSR document response

Ouverte
  • Quelque chose ne va pas ?
#633 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
76/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript
Domaine
backend-api-design, web-dev

Piste de recherche

Start in @solidjs/router/dist/data/query.js, around handleResponse at lines 248-263, and reproduce the issue with the provided Vite build and curl commands. Trace how respond() headers reach the SSR document response, then verify that envelope representation headers no longer replace text/html while needed redirect-related headers still work.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Versions
  • @solidjs/router 2.0.0-next.30 and 2.0.0-next.31
  • @solidjs/web 2.0.0-rc.11, solid-js 2.0.0-rc.11
  • @solidjs/vite-plugin 3.0.0-next.46 (start mode, ssr: true, serverFunctions: true, default renderMode)
  • vite 8.3.1, Node 24.20.0
Reproduction
// vite.config.ts
import { defineConfig } from 'vite'
import solid from '@solidjs/vite-plugin'

export default defineConfig({
  plugins: [solid({ start: { node: true }, ssr: true, serverFunctions: true })]
})

// src/data.ts
import { respond } from '@solidjs/web'

export async function thrownRead(): Promise<never> {
  'use server'
  await new Promise(resolve => setTimeout(resolve, 20))
  throw respond({ message: 'conflict' }, { status: 409 })
}

export async function returnedRead() {
  'use server'
  await new Promise(resolve => setTimeout(resolve, 20))
  return respond({ message: 'accepted' }, { status: 202 })
}

// src/pages.tsx
import { createMemo } from 'solid-js'
import { query } from '@solidjs/router'
import { returnedRead, thrownRead } from './data'

const getThrown = query(thrownRead, 'thrown')
const getReturned = query(returnedRead, 'returned')

export function Thrown() {
  const data = createMemo(() => getThrown())
  return <p>{String(data())}</p>
}

export function Returned() {
  const data = createMemo(() => getReturned())
  return <p>{data().message}</p>
}

export function Home() {
  return <p>home</p>
}

// src/router.ts
import { createRouter } from '@solidjs/router'
import { Home, Returned, Thrown } from './pages'

export const Router = createRouter({
  routes: [
    { path: '/', component: Home },
    { path: '/thrown', component: Thrown },
    { path: '/returned', component: Returned }
  ]
})

// src/App.tsx
import { Errored } from 'solid-js'
import { httpStatus } from '@solidjs/web'
import { Router } from './router'

function Failed() {
  httpStatus(500)
  return <p>failed</p>
}

export default function App() {
  return (
    <Errored fallback={() => <Failed />}>
      <Router>{props => props.children}</Router>
    </Errored>
  )
}

vite build
PORT=4399 node dist/server/node.js
curl -sS -D - -o /dev/null http://127.0.0.1:4399/
curl -sS -D - -o /dev/null http://127.0.0.1:4399/thrown
curl -sS -D - -o /dev/null http://127.0.0.1:4399/returned
Expected

Both documents keep content-type: text/html; charset=utf-8, like /. The envelope's Content-Type describes the envelope's own JSON body; it is not metadata for the page that read the query.

Actual
/          HTTP/1.1 200 OK                     content-type: text/html; charset=utf-8
/thrown    HTTP/1.1 500 Internal Server Error  content-type: application/json
/returned  HTTP/1.1 200 OK                     content-type: application/json

The body of both is the HTML document, so browsers render it as text. The server also logs twice:

[LATE_HEADER_WRITE] Response header write dropped: headers.set("content-type") ran after the response head was sent. Write headers before the shell flushes (or before the handler returns).

Same result with router 2.0.0-next.31.

Analysis (published files)
  1. respond() gives the carried Response Content-Type: application/json (@solidjs/web/dist/server.js, respond, line 520 in rc.11).
  2. A server function called directly during SSR runs with a shallow copy of the page event, so getRequestEvent().response inside the read is the page's response stub (@solidjs/web/server-functions/dist/server.js, around lines 1469-1477 in rc.11).
  3. query()'s handleResponse unwraps the envelope and then copies every header of envelope.response onto getRequestEvent().response (@solidjs/router/dist/data/query.js, lines 248-263 in next.30). For a returned or thrown respond(), that includes content-type.
  4. Copies that run before the shell flush end up on the document; later reads hit the committed stub and are dropped with [LATE_HEADER_WRITE].

The blanket header copy comes from #525 (for Set-Cookie on redirects). The envelope unwrap added in front of it later (c9f8c25a, "Adopt the core server-function protocol from @solidjs/web") now routes the envelope's body headers into it. The next branch at the 2.0.0-next.31 release still copies every header without a filter.

Possible fix

In handleResponse, skip representation headers (content-type, content-length, content-encoding, transfer-encoding) when copying from a Response or envelope onto e.response, and consider not writing to e.response once it is committed.

Related
  • #525: introduced the header copy in handleResponse.
  • #603 / #606: same handleResponse, redirect carrier only; the header copy is unchanged.
  • solidjs/solid#3433: added the [LATE_HEADER_WRITE] diagnostic.
  • solidjs/solid-start#2025: a different late header write through query() + redirect during SSR (closed as not planned).
Langage dominant
TypeScript
Étoiles
1.3k
Forks
180
Merge moyen
1 j 2 h
PR mergées (30 j)
26

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de solidjs/solid-router

Toutes les issues de solidjs/solid-router

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.