`query()` copies a `respond()` envelope's `Content-Type: application/json` onto the SSR document response
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 3/5
- 見積もり時間
- 1〜2日
- 初心者へのやさしさ
- 76/100
- issue の種類
- バグ
- 明瞭さ
- 明確に書かれている
- 活発さ
- 活発
- 技術スタック
- typescript
調査の方向性
Start in @solidjs/router/dist/data/query.js, around handleResponse at lines 248-263, and reproduce the issue with the provided Vite build and curl commands. Trace how respond() headers reach the SSR document response, then verify that envelope representation headers no longer replace text/html while needed redirect-related headers still work.
索引モデルが issue の本文から書いたものです。
説明
Versions
- @solidjs/router 2.0.0-next.30 and 2.0.0-next.31
- @solidjs/web 2.0.0-rc.11, solid-js 2.0.0-rc.11
- @solidjs/vite-plugin 3.0.0-next.46 (start mode,
ssr: true,serverFunctions: true, defaultrenderMode) - vite 8.3.1, Node 24.20.0
Reproduction
// vite.config.ts
import { defineConfig } from 'vite'
import solid from '@solidjs/vite-plugin'
export default defineConfig({
plugins: [solid({ start: { node: true }, ssr: true, serverFunctions: true })]
})
// src/data.ts
import { respond } from '@solidjs/web'
export async function thrownRead(): Promise<never> {
'use server'
await new Promise(resolve => setTimeout(resolve, 20))
throw respond({ message: 'conflict' }, { status: 409 })
}
export async function returnedRead() {
'use server'
await new Promise(resolve => setTimeout(resolve, 20))
return respond({ message: 'accepted' }, { status: 202 })
}
// src/pages.tsx
import { createMemo } from 'solid-js'
import { query } from '@solidjs/router'
import { returnedRead, thrownRead } from './data'
const getThrown = query(thrownRead, 'thrown')
const getReturned = query(returnedRead, 'returned')
export function Thrown() {
const data = createMemo(() => getThrown())
return <p>{String(data())}</p>
}
export function Returned() {
const data = createMemo(() => getReturned())
return <p>{data().message}</p>
}
export function Home() {
return <p>home</p>
}
// src/router.ts
import { createRouter } from '@solidjs/router'
import { Home, Returned, Thrown } from './pages'
export const Router = createRouter({
routes: [
{ path: '/', component: Home },
{ path: '/thrown', component: Thrown },
{ path: '/returned', component: Returned }
]
})
// src/App.tsx
import { Errored } from 'solid-js'
import { httpStatus } from '@solidjs/web'
import { Router } from './router'
function Failed() {
httpStatus(500)
return <p>failed</p>
}
export default function App() {
return (
<Errored fallback={() => <Failed />}>
<Router>{props => props.children}</Router>
</Errored>
)
}
vite build
PORT=4399 node dist/server/node.js
curl -sS -D - -o /dev/null http://127.0.0.1:4399/
curl -sS -D - -o /dev/null http://127.0.0.1:4399/thrown
curl -sS -D - -o /dev/null http://127.0.0.1:4399/returned
Expected
Both documents keep content-type: text/html; charset=utf-8, like /. The envelope's Content-Type describes the envelope's own JSON body; it is not metadata for the page that read the query.
Actual
/ HTTP/1.1 200 OK content-type: text/html; charset=utf-8
/thrown HTTP/1.1 500 Internal Server Error content-type: application/json
/returned HTTP/1.1 200 OK content-type: application/json
The body of both is the HTML document, so browsers render it as text. The server also logs twice:
[LATE_HEADER_WRITE] Response header write dropped: headers.set("content-type") ran after the response head was sent. Write headers before the shell flushes (or before the handler returns).
Same result with router 2.0.0-next.31.
Analysis (published files)
respond()gives the carried ResponseContent-Type: application/json(@solidjs/web/dist/server.js,respond, line 520 in rc.11).- A server function called directly during SSR runs with a shallow copy of the page event, so
getRequestEvent().responseinside the read is the page's response stub (@solidjs/web/server-functions/dist/server.js, around lines 1469-1477 in rc.11). query()'shandleResponseunwraps the envelope and then copies every header ofenvelope.responseontogetRequestEvent().response(@solidjs/router/dist/data/query.js, lines 248-263 in next.30). For a returned or thrownrespond(), that includescontent-type.- Copies that run before the shell flush end up on the document; later reads hit the committed stub and are dropped with
[LATE_HEADER_WRITE].
The blanket header copy comes from #525 (for Set-Cookie on redirects). The envelope unwrap added in front of it later (c9f8c25a, "Adopt the core server-function protocol from @solidjs/web") now routes the envelope's body headers into it. The next branch at the 2.0.0-next.31 release still copies every header without a filter.
Possible fix
In handleResponse, skip representation headers (content-type, content-length, content-encoding, transfer-encoding) when copying from a Response or envelope onto e.response, and consider not writing to e.response once it is committed.
Related
- #525: introduced the header copy in
handleResponse. - #603 / #606: same
handleResponse, redirect carrier only; the header copy is unchanged. - solidjs/solid#3433: added the
[LATE_HEADER_WRITE]diagnostic. - solidjs/solid-start#2025: a different late header write through
query()+ redirect during SSR (closed as not planned).
- 主要言語
- TypeScript
- スター
- 1.3k
- フォーク
- 180
- 平均マージ
- 1日 2時間
- マージ済み PR(30日)
- 26
環境構築
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
solidjs/solid-router のほかの issue
-
難易度 4/5 3〜5日 初心者へのやさしさ 50/100
solidjs/solid-router#625 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
難易度 3/5 1〜2日 初心者へのやさしさ 74/100
solidjs/solid-router#624 ·
メンテナーはふだん 1 日以内に返信
-
<A> costs ~6us of server CPU per instance during SSR (20x a plain <a>), mostly mergeProps/splitPropsオープン
難易度 4/5 3〜5日 初心者へのやさしさ 55/100
solidjs/solid-router#583 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
solidjs/solid-router#569 · コメント 3 件 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 3/5 1〜2日 初心者へのやさしさ 38/100
solidjs/solid-router#518 · コメント 2 件 ·
メンテナーはふだん 1 日以内に返信
solidjs/solid-router の issue をすべて見る
似ている issue
-
Mend: dependency security vulnerability untriaged
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
opensearch-project/security-dashboards-plugin#2545 ·
メンテナーはふだん 1 日以内に返信
-
Add: Dream TR SDオープンcheck:passed streams:add
難易度 2/5 1〜3時間 初心者へのやさしさ 70/100
メンテナーはふだん 1 日以内に返信
-
doctor integrity sample scans soft-deleted pages on Postgres (batch path has no deleted_at filter)オープン
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
メンテナーはふだん 1 日以内に返信
-
難易度 1/5 1時間未満 初心者へのやさしさ 72/100
SocialGouv/egapro#4672 · コメント 1 件 ·
メンテナーはふだん 2 日以内に返信
-
area:agents area:tui bug
難易度 2/5 1〜3時間 初心者へのやさしさ 74/100
anthropics/claude-code#98358 ·
メンテナーはふだん 1 日以内に返信