PlaceMarkersUsfmUpdateBlockHandler gets confused with table cells
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with the UpdateUsfm_TableCells test and the PlaceMarkersUsfmUpdateBlockHandler it uses, and run the test to see the output. The bug is that table-cell markers such as \tc1 get moved to the end of the row and \tr rows lose their cell markers. Done means the test's target USFM matches the input USFM exactly, with the existing PlaceMarkers tests still passing.
由索引模型根据 Issue 内容生成。
描述
The SF test team has noticed an issue where tables of a reasonably long length were getting garbled and out of order, both in normal builds and to a lesser degree (but still occurring) in echo builds. This particularly occurred with the SNHB DBL resource, which has a table in Numbers 1. The NLT does this too, but places verse markers in the table cells, which may alter the behavior of this bug.
The following test recreates the bug:
[Test]
public void UpdateUsfm_TableCells()
{
string source = "One Two Three Four Five Six Seven Eight Nine Ten Eleven Twelve Thirteen Fourteen Fifteen " +
"Sixteen Seventeen Eighteen Nineteen";
var alignInfo = new PlaceMarkersAlignmentInfo(
sourceTokens: [.. Tokenizer.Tokenize(source)],
translationTokens: [.. Tokenizer.Tokenize(source)],
alignment: ToWordAlignmentMatrix(
"0-0 1-1 2-2 3-3 4-4 5-5 6-6 7-7 8-8 9-9 10-10 11-11 12-12 13-13 14-14 15-15 16-16 17-17 18-18"
),
paragraphBehavior: UpdateUsfmMarkerBehavior.Preserve,
styleBehavior: UpdateUsfmMarkerBehavior.Strip
);
IReadOnlyList<UpdateUsfmRow> rows =
[
new UpdateUsfmRow(
ScrRef("MAT 1:1"),
source,
new Dictionary<string, object> { { "alignment_info", alignInfo } }
),
];
string usfm =
@"\id MAT
\c 1
\v 1 One
\tr \th1 Two \th2 Three
\tr \tc1 Four \tc2 Five
\tr \tc1 Six \tc2 Seven
\tr \tc1 Eight \tc2 Nine
\tr \tc1 Ten \tc2 Eleven
\tr \th1 Twelve \th2 Thirteen
\tr \tc1 Fourteen \tc2 Fifteen
\tr \tc1 Sixteen \tc2 Seventeen
\tr \tc1 Eighteen \tc2 Nineteen
";
string target = UpdateUsfm(
rows,
usfm,
paragraphBehavior: UpdateUsfmMarkerBehavior.Preserve,
usfmUpdateBlockHandlers: [new PlaceMarkersUsfmUpdateBlockHandler()]
);
AssertUsfmEquals(target, usfm);
}
The target USFM created by this test is:
\id MAT
\c 1
\v 1 One
\tr \th1 Two \th2 Three
\tr \tc1 Four \tc2 Five
\tr \tc1 Six \tc2 Seven
\tr \tc1 Eight \tc2 Nine \tc1
\tr Ten \tc2 Eleven
\tr \th1 Twelve \th2 Thirteen
\tr \tc1 Fourteen \tc2 Fifteen
\tr \tc1 Sixteen \tc2 Seventeen \tc1
\tr Eighteen \tc2 Nineteen
- 主要语言
- C#
- 星标
- 29
- 派生
- 16
- 平均合并
- 5 天 20 小时
- 30 天内合并 PR
- 11
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
sillsdev/machine 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
porting
难度 3/5 半天 新手友好度 25/100
sillsdev/machine#617 · 1 条评论 ·
维护者通常 1 天内回复
-
Hermit Crab
难度 4/5 3-5 天 新手友好度 18/100
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 48/100
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 48/100
维护者通常 1 天内回复
相似的 Issue
-
VB -> C#
难度 2/5 1-3 小时 新手友好度 72/100
icsharpcode/CodeConverter#1301 ·
维护者通常 3 天内回复
-
PettingZoo wrappers send only the first action component to every action dimension可能已有人在做 @RaphaelFakhri 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 73/100
Unity-Technologies/ml-agents#6341 ·
维护者通常 1 天内回复
-
Area: World-Readiness
难度 1/5 1 小时以内 新手友好度 90/100
microsoft/calculator#2522 ·
-
needs-triage
难度 2/5 1-3 小时 新手友好度 74/100
维护者通常 2 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 64/100