PlaceMarkersUsfmUpdateBlockHandler gets confused with table cells

Aperta
  • Qualcosa non va?
#614 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
62/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
csharp
Ambito
data

Direzione di ricerca

Start with the UpdateUsfm_TableCells test and the PlaceMarkersUsfmUpdateBlockHandler it uses, and run the test to see the output. The bug is that table-cell markers such as \tc1 get moved to the end of the row and \tr rows lose their cell markers. Done means the test's target USFM matches the input USFM exactly, with the existing PlaceMarkers tests still passing.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

The SF test team has noticed an issue where tables of a reasonably long length were getting garbled and out of order, both in normal builds and to a lesser degree (but still occurring) in echo builds. This particularly occurred with the SNHB DBL resource, which has a table in Numbers 1. The NLT does this too, but places verse markers in the table cells, which may alter the behavior of this bug.

The following test recreates the bug:

[Test]
public void UpdateUsfm_TableCells()
{
    string source = "One Two Three Four Five Six Seven Eight Nine Ten Eleven Twelve Thirteen Fourteen Fifteen " +
                    "Sixteen Seventeen Eighteen Nineteen";
    var alignInfo = new PlaceMarkersAlignmentInfo(
        sourceTokens: [.. Tokenizer.Tokenize(source)],
        translationTokens: [.. Tokenizer.Tokenize(source)],
        alignment: ToWordAlignmentMatrix(
            "0-0 1-1 2-2 3-3 4-4 5-5 6-6 7-7 8-8 9-9 10-10 11-11 12-12 13-13 14-14 15-15 16-16 17-17 18-18"
        ),
        paragraphBehavior: UpdateUsfmMarkerBehavior.Preserve,
        styleBehavior: UpdateUsfmMarkerBehavior.Strip
    );
    IReadOnlyList<UpdateUsfmRow> rows =
    [
        new UpdateUsfmRow(
            ScrRef("MAT 1:1"),
            source,
            new Dictionary<string, object> { { "alignment_info", alignInfo } }
        ),
    ];
    string usfm =
        @"\id MAT
\c 1
\v 1 One
\tr \th1 Two \th2 Three
\tr \tc1 Four \tc2 Five
\tr \tc1 Six \tc2 Seven
\tr \tc1 Eight \tc2 Nine
\tr \tc1 Ten \tc2 Eleven
\tr \th1 Twelve \th2 Thirteen
\tr \tc1 Fourteen \tc2 Fifteen
\tr \tc1 Sixteen \tc2 Seventeen
\tr \tc1 Eighteen \tc2 Nineteen
";

    string target = UpdateUsfm(
        rows,
        usfm,
        paragraphBehavior: UpdateUsfmMarkerBehavior.Preserve,
        usfmUpdateBlockHandlers: [new PlaceMarkersUsfmUpdateBlockHandler()]
    );

    AssertUsfmEquals(target, usfm);
}

The target USFM created by this test is:

\id MAT
\c 1
\v 1 One
\tr \th1 Two \th2 Three
\tr \tc1 Four \tc2 Five
\tr \tc1 Six \tc2 Seven
\tr \tc1 Eight \tc2 Nine \tc1
\tr Ten \tc2 Eleven
\tr \th1 Twelve \th2 Thirteen
\tr \tc1 Fourteen \tc2 Fifteen
\tr \tc1 Sixteen \tc2 Seventeen \tc1
\tr Eighteen \tc2 Nineteen
Lingua principale
C#
Stelle
29
Fork
16
Merge medio
6g 7h
PR unite (30g)
14

Preparare l'ambiente

  • Nessun Dockerfile né file Docker Compose
  • Ha un modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di sillsdev/machine

Tutte le issue di sillsdev/machine

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.