Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

WebSockets rewrite

未关闭
#4 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
25/100
Issue 类型
重构
描述清晰度
需要澄清
活跃度
停滞
技术栈
javascript, nodejs, wordpress
领域
api, backend

调研方向

Review the changes described for wsConnectUserToServer in api2.js, the wpIdentity WebSocket package switch, and the Caddy configuration shown in the issue. Check the server log and client behavior against the retry limits and WebSocket routing; done means failed connections no longer retry indefinitely or fall back to HTTP unexpectedly.

由索引模型根据 Issue 内容生成。

描述

There have been problems over time with the WebSocket functionality in WordLand and wpIdentity. But I think I've gotten it stabilized, and since @scotthansonde was involved in this, a long time ago, I thought I should close the loop.

  1. I rewrote wsConnectUserToServer in api2.js to wait 10 seconds between retries after a failed connection, and to only try 100 times, and after that it gives up. You can reload the page to get another set of tries. Previously it waited 1 second and retried indefinitely.
  2. I switched the websockets package wpIdentity was using from nodejs-websocket to ws. This was based on advice I got from ChatGPT and Claude.ai, saying that nodejs-websocket was not being maintained, and the gold standard for everyone was ws.
  3. I changed the Caddy config file on the server, per the advice of ChatGPT, to make sure that failed WS connections didn't fall back to HTTP connections, which is what I was seeing in the logfile, along with the steady stream of errors in the user's JS console (this came up the other day in a bug report on the wordlandSupport repo issues list.

The result? It's much calmer in the server log. This is kind of mysterious, I didn't expect it to settle down so quickly because there must have been some old clients out there reconnecting every second?

The new Caddy file
{
  on_demand_tls {
    ask http://localhost:1339/isdomainvalid
  }
}

https:// {
  tls {
    on_demand
  }

  @websocketsWordlandSocial {
    host wordland.social
    header Connection *Upgrade*
    header Upgrade    websocket
  }

  @httpWordlandSocial {
    host wordland.social
  }

  reverse_proxy @websocketsWordlandSocial localhost:1502
  reverse_proxy @httpWordlandSocial localhost:1339

  # Optional: fallback for other domains
  reverse_proxy localhost:1339
} 

Screen shot of server log with a client trying to connect every second

Image

主要语言
JavaScript
星标
21
派生
2
PR 合并指标
30 天内没有已合并 PR

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

scripting/wpIdentity 的其他 Issue

查看 scripting/wpIdentity 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。