NamespaceManagement revocation checks labels on the wrong namespace
维护者通常 1 天内回复
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 25/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- go, kubernetes
调研方向
Start in argocd-operator/controllers/argocd/util.go at handleNamespaceManagementDelete and handleNamespaceManagementUpdate, where the cleanup fetches the namespace named by .spec.managedBy instead of the CR's own namespace. Reproduce the deletion case with the fake client first. Done when the target namespace's labels decide whether the old manager's Roles and RoleBindings are revoked, with regression tests for deletion, retargeting, and a preserved valid target-label grant.
由索引模型根据 Issue 内容生成。
描述
Deleting or redirecting a NamespaceManagement CR can leave the old ArgoCD instance's cross-namespace permissions in place. The cleanup checks the managing namespace's labels instead of the namespace withdrawing consent.
Reproduction
With ALLOW_NAMESPACE_MANAGEMENT_IN_NAMESPACE_SCOPED_INSTANCES=true:
- Create a namespace-scoped ArgoCD instance in
manager, with.spec.namespaceManagement: [{name: target, allowManagedBy: true}]. - Label namespace
managerwithargocd.argoproj.io/managed-by: manager. Leave namespacetargetwithout amanaged-bylabel. - Create a NamespaceManagement CR in
targetwith.spec.managedBy: manager, and wait for the cross-namespace Roles and RoleBindings to be created. - Delete that NamespaceManagement CR, or change its
.spec.managedByto another namespace.
Actual behavior
The cleanup handlers fetch namespace manager using .spec.managedBy. Its self-referencing managed-by label causes cleanup to be skipped, although target has no overlapping label grant. The old manager's Roles and RoleBindings remain in target, retaining access after consent is withdrawn.
Relevant code: argocd-operator/controllers/argocd/util.go, in handleNamespaceManagementUpdate at line 2026 and handleNamespaceManagementDelete at line 2048.
Expected behavior
Check the labels on the NamespaceManagement CR's own namespace (target). Revoke the old manager's grants unless that target namespace independently authorizes continued access. Add regression tests for deletion and retargeting with a self-labeled manager, plus a case preserving a valid target-namespace label grant.
Confirmed the deletion case at commit 5fb7a030 using an isolated fake-client reproduction after a prior grant; no live-cluster exploit was run.
(Bug text c/o OpenAI Codex v6.1 Sol xhigh)
- 主要语言
- Go
- 星标
- 190
- 派生
- 367
- 平均合并
- 4 天 2 小时
- 30 天内合并 PR
- 63
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
redhat-developer/gitops-operator 的其他 Issue
-
Manager does not detect Route CRD that appears after startup可能已有人在做 @atishay-kasliwal 今天认领。 未关闭
难度 4/5 3-5 天 新手友好度 48/100
redhat-developer/gitops-operator#1566 · 1 条评论 ·
维护者通常 1 天内回复
-
Deleting an ArgoCD instance removes RBAC belonging to same-named instances可能已有人在做 @Rizwana777 于 3 天前认领。 未关闭kind/bug
难度 3/5 1-2 天 新手友好度 45/100
redhat-developer/gitops-operator#1558 · 已指派 1 人 ·
维护者通常 1 天内回复
-
NamespaceManagement cleanup can delete RBAC in unrelated namespaces可能已有人在做 @Rizwana777 于 3 天前认领。 未关闭kind/bug
难度 4/5 3-5 天 新手友好度 22/100
redhat-developer/gitops-operator#1557 · 已指派 1 人 ·
维护者通常 1 天内回复
-
ApplicationSet tokenRef strict mode changes only apply after the controller is restarted可能已有人在做 @Gabrielandre02 于 5 天前认领。 未关闭
redhat-developer/gitops-operator#1554 · 1 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
-
Enqueue the previous Argo CD instance when NamespaceManagement consent is withdrawn可能已有人在做 @Gabrielandre02 于 5 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 25/100
redhat-developer/gitops-operator#1530 · 1 条评论 ·
维护者通常 1 天内回复
查看 redhat-developer/gitops-operator 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
Inconsistency between golang and cue in spec可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 1/5 1 小时以内 新手友好度 88/100
维护者通常 1 天内回复
-
security
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 2/5 1-3 小时 新手友好度 73/100
Tencent/LoopForge#1087 · 1 条评论 ·
维护者通常 1 天内回复