Migrate native spec imports to the public React Native API

未关闭
  • 哪里不对？
#1,070 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
58/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
活跃
技术栈
javascript, react-native
领域
mobile, tooling

调研方向

Start with src/specs/DateTimePickerNativeComponent.js and compare its React Native imports with the public Codegen exports documented in the issue. Then inspect the remaining native module specifications for private React Native imports and check the supported React Native versions before deciding whether the minimum version needs to change. Done means the specifications use supported public imports with their existing annotations and defaults preserved, and the compatibility implications are addressed.

由索引模型根据 Issue 内容生成。

描述

Summary

@react-native-community/[email protected] uses private React Native imports in its native component specification. The current upstream specification still contains these imports.

React Native introduced its Strict TypeScript API in 0.80 and enabled it by default in 0.87. React Native documents public package-root exports for Codegen types and helpers as the supported migration path.

Affected imports

In src/specs/DateTimePickerNativeComponent.js:

import type {ViewProps} from 'react-native/Libraries/Components/View/ViewPropTypes';
import type {ColorValue} from 'react-native/Libraries/StyleSheet/StyleSheet';
import type {
  BubblingEventHandler,
  Double,
  Int32,
  WithDefault,
} from 'react-native/Libraries/Types/CodegenTypes';
import codegenNativeComponent from 'react-native/Libraries/Utilities/codegenNativeComponent';

Suggested change

Use the public package-root exports:

import type {ViewProps, ColorValue, HostComponent, CodegenTypes} from 'react-native';
import {codegenNativeComponent} from 'react-native';

Update the specification's numeric, event-handler, and default-value annotations to CodegenTypes.Double, CodegenTypes.Int32, CodegenTypes.BubblingEventHandler, and CodegenTypes.WithDefault, preserving their existing signatures and defaults.

Please check the remaining native module specifications for private React Native imports as part of this migration, and account for the library's supported React Native versions when deciding whether a minimum-version change is needed.

Scope and compatibility

  • Library version: 9.1.0
  • Target React Native version: 0.87.1
  • Scope: native specification import migration, not a platform-specific picker runtime failure.
  • This particular component specification is Flow source. This report does not claim that a normal TypeScript consumer necessarily typechecks this .js file or fails merely by importing the library; it requests migration away from the private paths to the documented public API.
  • This report is based on source inspection. No standalone reproduction repository is attached.

References

AI disclosure: GitHub Copilot assisted with researching and drafting this issue

主要语言
JavaScript
星标
2.9k
派生
459
平均合并
4 天 16 小时
30 天内合并 PR
5

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

react-native-datetimepicker/datetimepicker 的其他 Issue

查看 react-native-datetimepicker/datetimepicker 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。