Migrate native spec imports to the public React Native API

Aperta
  • Qualcosa non va?
#1,070 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
58/100
Tipo di issue
Refactoring
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
javascript, react-native
Ambito
mobile, tooling

Direzione di ricerca

Start with src/specs/DateTimePickerNativeComponent.js and compare its React Native imports with the public Codegen exports documented in the issue. Then inspect the remaining native module specifications for private React Native imports and check the supported React Native versions before deciding whether the minimum version needs to change. Done means the specifications use supported public imports with their existing annotations and defaults preserved, and the compatibility implications are addressed.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

@react-native-community/[email protected] uses private React Native imports in its native component specification. The current upstream specification still contains these imports.

React Native introduced its Strict TypeScript API in 0.80 and enabled it by default in 0.87. React Native documents public package-root exports for Codegen types and helpers as the supported migration path.

Affected imports

In src/specs/DateTimePickerNativeComponent.js:

import type {ViewProps} from 'react-native/Libraries/Components/View/ViewPropTypes';
import type {ColorValue} from 'react-native/Libraries/StyleSheet/StyleSheet';
import type {
  BubblingEventHandler,
  Double,
  Int32,
  WithDefault,
} from 'react-native/Libraries/Types/CodegenTypes';
import codegenNativeComponent from 'react-native/Libraries/Utilities/codegenNativeComponent';

Suggested change

Use the public package-root exports:

import type {ViewProps, ColorValue, HostComponent, CodegenTypes} from 'react-native';
import {codegenNativeComponent} from 'react-native';

Update the specification's numeric, event-handler, and default-value annotations to CodegenTypes.Double, CodegenTypes.Int32, CodegenTypes.BubblingEventHandler, and CodegenTypes.WithDefault, preserving their existing signatures and defaults.

Please check the remaining native module specifications for private React Native imports as part of this migration, and account for the library's supported React Native versions when deciding whether a minimum-version change is needed.

Scope and compatibility

  • Library version: 9.1.0
  • Target React Native version: 0.87.1
  • Scope: native specification import migration, not a platform-specific picker runtime failure.
  • This particular component specification is Flow source. This report does not claim that a normal TypeScript consumer necessarily typechecks this .js file or fails merely by importing the library; it requests migration away from the private paths to the documented public API.
  • This report is based on source inspection. No standalone reproduction repository is attached.

References

AI disclosure: GitHub Copilot assisted with researching and drafting this issue

Lingua principale
JavaScript
Stelle
2.9k
Fork
459
Merge medio
4g 16h
PR unite (30g)
5

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di react-native-datetimepicker/datetimepicker

Tutte le issue di react-native-datetimepicker/datetimepicker

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.