Migrate native spec imports to the public React Native API

オープン
  • 何か問題がありますか？
#1,070 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
58/100
issue の種類
リファクタリング
明瞭さ
おおむね明確
活発さ
活発
技術スタック
javascript, react-native
領域
mobile, tooling

調査の方向性

Start with src/specs/DateTimePickerNativeComponent.js and compare its React Native imports with the public Codegen exports documented in the issue. Then inspect the remaining native module specifications for private React Native imports and check the supported React Native versions before deciding whether the minimum version needs to change. Done means the specifications use supported public imports with their existing annotations and defaults preserved, and the compatibility implications are addressed.

索引モデルが issue の本文から書いたものです。

説明

Summary

@react-native-community/[email protected] uses private React Native imports in its native component specification. The current upstream specification still contains these imports.

React Native introduced its Strict TypeScript API in 0.80 and enabled it by default in 0.87. React Native documents public package-root exports for Codegen types and helpers as the supported migration path.

Affected imports

In src/specs/DateTimePickerNativeComponent.js:

import type {ViewProps} from 'react-native/Libraries/Components/View/ViewPropTypes';
import type {ColorValue} from 'react-native/Libraries/StyleSheet/StyleSheet';
import type {
  BubblingEventHandler,
  Double,
  Int32,
  WithDefault,
} from 'react-native/Libraries/Types/CodegenTypes';
import codegenNativeComponent from 'react-native/Libraries/Utilities/codegenNativeComponent';

Suggested change

Use the public package-root exports:

import type {ViewProps, ColorValue, HostComponent, CodegenTypes} from 'react-native';
import {codegenNativeComponent} from 'react-native';

Update the specification's numeric, event-handler, and default-value annotations to CodegenTypes.Double, CodegenTypes.Int32, CodegenTypes.BubblingEventHandler, and CodegenTypes.WithDefault, preserving their existing signatures and defaults.

Please check the remaining native module specifications for private React Native imports as part of this migration, and account for the library's supported React Native versions when deciding whether a minimum-version change is needed.

Scope and compatibility

  • Library version: 9.1.0
  • Target React Native version: 0.87.1
  • Scope: native specification import migration, not a platform-specific picker runtime failure.
  • This particular component specification is Flow source. This report does not claim that a normal TypeScript consumer necessarily typechecks this .js file or fails merely by importing the library; it requests migration away from the private paths to the documented public API.
  • This report is based on source inspection. No standalone reproduction repository is attached.

References

AI disclosure: GitHub Copilot assisted with researching and drafting this issue

主要言語
JavaScript
スター
2.9k
フォーク
459
平均マージ
4日 16時間
マージ済み PR（30日）
5

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

react-native-datetimepicker/datetimepicker のほかの issue

react-native-datetimepicker/datetimepicker の issue をすべて見る

似ている issue

JavaScript の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。