Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

CompositeContentGuard should return a 401 authentication challenge when a sub-guard requires authentication

未关闭
  • 哪里不对？
#8,245 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
python
领域
api, authentication, backend

调研方向

Read pulpcore/app/models/publication.py and pulpcore/content/handler.py, then inspect the content guard and handler tests for permission failures and cached authentication. Implement the configurable authentication challenge across composite guards and the handler. Done means missing authentication returns 401 with WWW-Authenticate, authorization denial remains 403, and an allowed sub-guard still permits access.

由索引模型根据 Issue 内容生成。

描述

Issue

Problem

CompositeContentGuard.permit() evaluates its sub-guards with OR semantics: the first guard that passes permits the request, and if all guards fail it raises a single PermissionError. The content app handler translates that PermissionError into an HTTP 403 Forbidden.

This conflates two distinct situations:

  1. Authorization denied — the request has an identity, but that identity is not allowed. 403 Forbidden is correct.
  2. Authentication missing — the request carried no identity at all. The correct HTTP response is 401 Unauthorized with a WWW-Authenticate challenge, so the client knows it should authenticate and retry.

Because CompositeContentGuard only knows about PermissionError, a request that fails purely for lack of authentication still gets a flat 403. A client (e.g. a package manager, or a browser behind basic auth) never receives the WWW-Authenticate challenge and has no signal to supply credentials.

Current behavior

pulpcore/app/models/publication.py — CompositeContentGuard.permit():

for guard in self.guards.all():
    detail_guard = guard.cast()
    try:
        detail_guard.permit(request)
        return  # success on first-pass
    except PermissionError as pe:
        errors.append(...)

# If we get here - FAIL
raise PermissionError(_("Access forbidden. Refusals: {}").format(errors))

pulpcore/content/handler.py — _permit() maps any PermissionError to HTTPForbidden (403). There is no path that produces a 401 with a WWW-Authenticate header.

Proposed behavior

  1. Introduce (or adopt) a distinct exception that a content guard can raise to mean "authentication required" rather than "forbidden" — e.g. an AuthenticationError separate from PermissionError.
  2. In CompositeContentGuard.permit(), track whether any sub-guard raised the authentication-required error. If no guard passes and at least one raised authentication-required, re-raise that authentication error instead of the generic PermissionError. (Authorization denials still collapse to PermissionError → 403.)
  3. In the content handler's _permit(), translate the authentication-required error into HTTPUnauthorized (401) with a WWW-Authenticate challenge header. Also update the cached-auth path so a 401 is handled like a 403 (not cached as a pass).

This preserves the OR semantics: if any guard permits, access is granted; a 401 is only returned when the sole reason for failure is missing authentication.

Reference implementation

pulp-service already carries this as a downstream patch and it works in production for packages.redhat.com:

https://github.com/pulp/pulp-service/blob/main/images/assets/patches/0078-Return-authentication-challenge-for-missing-identity.patch

The patch:

  • Catches a new AuthenticationError in CompositeContentGuard.permit(), remembers the first one, and re-raises it after the loop if no guard passed.
  • Catches AuthenticationError in handler._permit() and raises HTTPUnauthorized with WWW-Authenticate: Basic realm="packages.redhat.com".
  • Updates auth_cached() to treat HTTPUnauthorized like HTTPForbidden and to avoid caching when the guard result is indeterminate.

Upstreaming this would require a general mechanism (the realm / challenge value should be configurable rather than hard-coded), but the core behavior — a composite guard surfacing an authentication challenge instead of a blanket 403 — belongs in pulpcore.

主要语言
Python
星标
619
派生
176
平均合并
16 小时 49 分钟
30 天内合并 PR
126

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

pulp/pulpcore 的其他 Issue

查看 pulp/pulpcore 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。