Hacktoberfest 2026：メンテナが10月に向けて印を付けた、オープンで初心者向けの issue。 Hacktoberfest の issue を見る

CompositeContentGuard should return a 401 authentication challenge when a sub-guard requires authentication

オープン
  • 何か問題がありますか？
#8,245 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
45/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
技術スタック
python
領域
api, authentication, backend

調査の方向性

Read pulpcore/app/models/publication.py and pulpcore/content/handler.py, then inspect the content guard and handler tests for permission failures and cached authentication. Implement the configurable authentication challenge across composite guards and the handler. Done means missing authentication returns 401 with WWW-Authenticate, authorization denial remains 403, and an allowed sub-guard still permits access.

索引モデルが issue の本文から書いたものです。

説明

Issue Triage-Needed

Problem

CompositeContentGuard.permit() evaluates its sub-guards with OR semantics: the first guard that passes permits the request, and if all guards fail it raises a single PermissionError. The content app handler translates that PermissionError into an HTTP 403 Forbidden.

This conflates two distinct situations:

  1. Authorization denied — the request has an identity, but that identity is not allowed. 403 Forbidden is correct.
  2. Authentication missing — the request carried no identity at all. The correct HTTP response is 401 Unauthorized with a WWW-Authenticate challenge, so the client knows it should authenticate and retry.

Because CompositeContentGuard only knows about PermissionError, a request that fails purely for lack of authentication still gets a flat 403. A client (e.g. a package manager, or a browser behind basic auth) never receives the WWW-Authenticate challenge and has no signal to supply credentials.

Current behavior

pulpcore/app/models/publication.py — CompositeContentGuard.permit():

for guard in self.guards.all():
    detail_guard = guard.cast()
    try:
        detail_guard.permit(request)
        return  # success on first-pass
    except PermissionError as pe:
        errors.append(...)

# If we get here - FAIL
raise PermissionError(_("Access forbidden. Refusals: {}").format(errors))

pulpcore/content/handler.py — _permit() maps any PermissionError to HTTPForbidden (403). There is no path that produces a 401 with a WWW-Authenticate header.

Proposed behavior

  1. Introduce (or adopt) a distinct exception that a content guard can raise to mean "authentication required" rather than "forbidden" — e.g. an AuthenticationError separate from PermissionError.
  2. In CompositeContentGuard.permit(), track whether any sub-guard raised the authentication-required error. If no guard passes and at least one raised authentication-required, re-raise that authentication error instead of the generic PermissionError. (Authorization denials still collapse to PermissionError → 403.)
  3. In the content handler's _permit(), translate the authentication-required error into HTTPUnauthorized (401) with a WWW-Authenticate challenge header. Also update the cached-auth path so a 401 is handled like a 403 (not cached as a pass).

This preserves the OR semantics: if any guard permits, access is granted; a 401 is only returned when the sole reason for failure is missing authentication.

Reference implementation

pulp-service already carries this as a downstream patch and it works in production for packages.redhat.com:

https://github.com/pulp/pulp-service/blob/main/images/assets/patches/0078-Return-authentication-challenge-for-missing-identity.patch

The patch:

  • Catches a new AuthenticationError in CompositeContentGuard.permit(), remembers the first one, and re-raises it after the loop if no guard passed.
  • Catches AuthenticationError in handler._permit() and raises HTTPUnauthorized with WWW-Authenticate: Basic realm="packages.redhat.com".
  • Updates auth_cached() to treat HTTPUnauthorized like HTTPForbidden and to avoid caching when the guard result is indeterminate.

Upstreaming this would require a general mechanism (the realm / challenge value should be configurable rather than hard-coded), but the core behavior — a composite guard surfacing an authentication challenge instead of a blanket 403 — belongs in pulpcore.

主要言語
Python
スター
612
フォーク
175
平均マージ
15時間 47分
マージ済み PR（30日）
117

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

pulp/pulpcore のほかの issue

pulp/pulpcore の issue をすべて見る

似ている issue

Python の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。