Thread reboots leak static TLS when OPcache is loaded but disabled (opcache.enable=0): extensions stop loading
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 45/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
调研方向
Start by tracing rebootAllThreads() and frankenphp_new_main_thread, then compare PHP module startup and shutdown when OPcache is disabled versus enabled. The report provides a Docker reproduction using intl and worker restarts; reproduce the static TLS allocation failure and verify whether the change prevents extensions from disappearing after repeated reboots.
由索引模型根据 Issue 内容生成。
描述
What happened?
Prepared with an AI assistant (Claude), which ran the investigation and the reproduction below on my machine; I asked for this report.
With OPcache loaded but disabled (opcache.enable=0), every reboot of FrankenPHP's PHP threads (a worker restart through the admin API, or a file change with watch) leaks static TLS. After enough reboots, extensions can no longer be loaded at the next PHP startup:
PHP Warning: PHP Startup: Unable to load dynamic library 'intl' (tried: …/intl (…: cannot open shared object file: No such file or directory), …/no-debug-zts-20240924/intl.so (…/intl.so: cannot allocate memory in static TLS block)) in Unknown on line 0
From then on the extension is missing in every request until the process is restarted (Class "Locale" not found, …). In our app (about 30 extensions, watch in development) this happened after about 95 saved files; with imagick the victim was libgomp.so.1: cannot allocate memory in static TLS block.
Minimal reproduction (official image, only intl)
Dockerfile:
FROM dunglas/frankenphp:1.13.1-php8.4-trixie
RUN install-php-extensions intl
Caddyfile:
{
frankenphp {
worker /app/public/worker.php 2
php_ini opcache.enable 0
}
}
:80 {
root * /app/public
php_server
}
public/worker.php:
<?php
while (frankenphp_handle_request(static function (): void {
echo 'worker';
})) {
gc_collect_cycles();
}
public/check.php:
<?php
echo extension_loaded('intl') ? 'intl loaded' : 'intl MISSING';
docker build -t fp-tls .
docker run -d --name fp-tls -v "$PWD/Caddyfile:/etc/frankenphp/Caddyfile:ro" -v "$PWD/public:/app/public:ro" fp-tls
for i in $(seq 1 1000); do
docker exec fp-tls curl -s -X POST localhost:2019/frankenphp/workers/restart >/dev/null
docker logs fp-tls 2>&1 | grep -q 'static TLS' && break
done
echo "after $i restarts: $(docker exec fp-tls curl -s localhost/check.php)"
Results (x86_64):
| Setup | Result |
|---|---|
php_ini opcache.enable 0 (OPcache loaded, disabled) |
intl fails to load after 215 restarts |
OPcache enabled (the same without the php_ini line) |
no failure in 1000 restarts |
OPcache not loaded (rm /usr/local/etc/php/conf.d/docker-php-ext-opcache.ini) |
no failure in 600 restarts |
Our app's image, ~30 extensions, opcache.enable 0 |
fails after 95 restarts |
The same, without the php_ini opcache.enable 0 line |
no failure in 150 restarts |
Likely cause
When OPcache is enabled, accel_startup() sets extension->handle = 0 ("Prevent unloading", ext/opcache/ZendAccelerator.c), so opcache.so stays loaded. When it is disabled, accel_startup() returns before that, so opcache.so is unloaded at module shutdown and loaded again by the php_module_startup() that rebootAllThreads() runs (frankenphp_new_main_thread). It looks like glibc does not give back the static TLS of the unloaded ZTS module, so every reboot takes more of the surplus until another extension no longer fits. This is our reading of the source and the measurements; we have not traced glibc's allocator.
Why opcache.enable=0, and workarounds
We disabled OPcache because of the OPcache races under ZTS (php-src GH-8739, #23637, #24319; see also #2714, #2715): in worker mode, restarting workers under load crashed the process with zend_mm_heap corrupted about once in 20 to 50 restarts on PHP 8.4.26.
What worked for us:
- Not loading OPcache instead of disabling it (what we use now).
- Raising glibc's reserve with
GLIBC_TUNABLES=glibc.rtld.optional_static_tls=1048576: 400 reboots without failure. Note that glibc ignoresGLIBC_TUNABLESfor the image's/usr/local/bin/frankenphp, because itscap_net_bind_servicefile capability puts it in secure-execution mode. A copy of the binary without the capability honoured it.
Perhaps worth a note in the docs (disable OPcache by not loading it, not with opcache.enable=0). Alternatively, keep extensions loaded across a thread reboot, as an enabled OPcache does for itself. You know the trade-offs there better than we do.
Build Type
Docker (Debian Trixie)
Worker Mode
Yes
Operating System
GNU/Linux
CPU Architecture
x86_64
PHP configuration
phpinfo() output
FrankenPHP v1.13.1 PHP 8.4.26 Caddy v2.11.7 (dunglas/frankenphp:1.13.1-php8.4-trixie)
Thread Safety => enabled
glibc 2.41 (Debian 13), host kernel Linux 7.2 x86_64, Docker
Extensions: the image's defaults + intl (installed with install-php-extensions)
php_ini opcache.enable 0
Relevant log output
Relevant log output
(after many "rebooting all PHP threads" / "workers restarted from admin api")
{"level":"warn","ts":1792408364.6600497,"logger":"frankenphp","msg":"PHP Warning: PHP Startup: Unable to load dynamic library 'intl' (tried: /usr/local/lib/php/extensions/no-debug-zts-20240924/intl (/usr/local/lib/php/extensions/no-debug-zts-20240924/intl: cannot open shared object file: No such file or directory), /usr/local/lib/php/extensions/no-debug-zts-20240924/intl.so (/usr/local/lib/php/extensions/no-debug-zts-20240924/intl.so: cannot allocate memory in static TLS block)) in Unknown on line 0","syslog_level":"warning"}
- 主要语言
- Go
- 星标
- 11.4k
- 派生
- 494
- 平均合并
- 2 天 1 小时
- 30 天内合并 PR
- 25
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
php/frankenphp 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 90/100
php/frankenphp#2671 · 1 条评论 ·
维护者通常 1 天内回复
-
Include frankenphp version in logs可能已有人在做 @ousamabenyounes 于 92 天前认领。 未关闭enhancement
难度 2/5 1-3 小时 新手友好度 68/100
php/frankenphp#2483 · 3 条评论 ·
维护者通常 1 天内回复
-
suggestion about compile.md可能重新可做 关联的 PR 已关闭且未合并。 未关闭enhancement
难度 1/5 1-3 小时 新手友好度 68/100
php/frankenphp#601 · 5 条评论 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 35/100
php/frankenphp#2732 · 9 条评论 · 17 个 reaction ·
维护者通常 1 天内回复
-
Feature Request: Include ACME DNS modules (e.g. Cloudflare) in official Windows pre-built binaries未关闭enhancement
难度 5/5 一周以上 新手友好度 35/100
php/frankenphp#2731 ·
维护者通常 1 天内回复
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
Mend: dependency security vulnerability
难度 2/5 1-3 小时 新手友好度 72/100
kube-tarian/sigrun#202 ·
-
good first issue help wanted
难度 2/5 1-3 小时 新手友好度 82/100
eugenioenko/ttt#1085 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 62/100
fullsend-ai/fullsend#8688 · 1 条评论 ·
维护者通常 1 天内回复
-
question raised-by:verifier
难度 2/5 1-3 小时 新手友好度 72/100
medici-finance/assay#4013 ·
维护者通常 1 天内回复