Please do not disallow the `+` character in user IDs

未关闭
#2,542 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 4 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
半天
新手友好度
38/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
冷清
技术栈
perl

调研方向

The payload names no files, so start by searching the repository for the user ID validation rule and the code that extracts a user ID from the Canvas email, and check where + is rejected. Confirm the restriction applies in both places. Done means a user ID containing + is accepted and works through the Canvas login path. Check that the design question about allowed characters has been settled before you change the rule.

由索引模型根据 Issue 内容生成。

描述

This is a feature request to allow the + character as part of user IDs.

Why? One of the biggest difficulties for our WeBWorK setup is that I can't properly test Canvas integration without having a real student account in Canvas. The student account I was able to get in the end is tied to a special email with a + character in it. Gmail, as well as some other systems, support using [email protected] and treat it as equivalent to [email protected]. This makes it possible to use different variations on the same email address, all pointing to the same inbox.

Since WeBWorK is set up to extract the user ID from the email that Canvas sends, I end up with a user ID that contains a + character. The actual user ID that Canvas uses also has a + character (it's the full email).

Generally, allowing the + character would make it much easier for me to debug issues in out environment.

主要语言
Perl
星标
164
派生
167
平均合并
6 天 7 小时
30 天内合并 PR
27

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

openwebwork/webwork2 的其他 Issue

查看 openwebwork/webwork2 的全部 Issue

相似的 Issue

更多 Perl Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。