Please do not disallow the `+` character in user IDs

Aperta
#2,542 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 4 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
Mezza giornata
Idoneità per principianti
38/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Tranquilla
Stack tecnologico
perl

Direzione di ricerca

The payload names no files, so start by searching the repository for the user ID validation rule and the code that extracts a user ID from the Canvas email, and check where + is rejected. Confirm the restriction applies in both places. Done means a user ID containing + is accepted and works through the Canvas login path. Check that the design question about allowed characters has been settled before you change the rule.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

This is a feature request to allow the + character as part of user IDs.

Why? One of the biggest difficulties for our WeBWorK setup is that I can't properly test Canvas integration without having a real student account in Canvas. The student account I was able to get in the end is tied to a special email with a + character in it. Gmail, as well as some other systems, support using [email protected] and treat it as equivalent to [email protected]. This makes it possible to use different variations on the same email address, all pointing to the same inbox.

Since WeBWorK is set up to extract the user ID from the email that Canvas sends, I end up with a user ID that contains a + character. The actual user ID that Canvas uses also has a + character (it's the full email).

Generally, allowing the + character would make it much easier for me to debug issues in out environment.

Lingua principale
Perl
Stelle
164
Fork
167
Merge medio
6g 7h
PR unite (30g)
27

Preparare l'ambiente

  • Include un Dockerfile o un file Docker Compose
  • Nessun modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di openwebwork/webwork2

Tutte le issue di openwebwork/webwork2

Issue simili

Altre issue su Perl

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.