Please do not disallow the `+` character in user IDs

Abierto
#2,542 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 4 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
Medio día
Aptitud para principiantes
38/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Tranquilo
Stack tecnológico
perl

Línea de trabajo

The payload names no files, so start by searching the repository for the user ID validation rule and the code that extracts a user ID from the Canvas email, and check where + is rejected. Confirm the restriction applies in both places. Done means a user ID containing + is accepted and works through the Canvas login path. Check that the design question about allowed characters has been settled before you change the rule.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

This is a feature request to allow the + character as part of user IDs.

Why? One of the biggest difficulties for our WeBWorK setup is that I can't properly test Canvas integration without having a real student account in Canvas. The student account I was able to get in the end is tied to a special email with a + character in it. Gmail, as well as some other systems, support using [email protected] and treat it as equivalent to [email protected]. This makes it possible to use different variations on the same email address, all pointing to the same inbox.

Since WeBWorK is set up to extract the user ID from the email that Canvas sends, I end up with a user ID that contains a + character. The actual user ID that Canvas uses also has a + character (it's the full email).

Generally, allowing the + character would make it much easier for me to debug issues in out environment.

Lenguaje dominante
Perl
Estrellas
164
Forks
167
Merge medio
6 d 7 h
PR fusionados (30 d)
27

Preparar el entorno

  • Incluye un Dockerfile o un archivo de Docker Compose
  • Sin plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de openwebwork/webwork2

Todos los issues de openwebwork/webwork2

Issues similares

Más issues de Perl

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.