guild crest: every upload is refused on our shard (no crest store: SRO_AGENT_MARKS_DIR unset)

未关闭
#3,454 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
半天
新手友好度
25/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
go

调研方向

Start in cmd/services/sro-gameworld/wiring_authority.go, where the crest store opens only when SRO_AGENT_MARKS_DIR is set, and at crestregister.go:165 where uploads are refused. The fix lives in the deployment config: server-ops/nomad/jobs/gameworld.nomad.hcl in the opensro-ops repo, which needs a persistent directory owned by the GameWorld user. Confirm the live process environment first. Done means a valid 16×16 crest upload is accepted and shown over a guild member, and this is blocked until #3451 is merged.

由索引模型根据 Issue 内容生成。

描述

area: ops bug priority: high

Player report (bug-reports forum, 2026-11-12): the guild crest dialog lets the player pick a .bmp file, but the game does not accept it.

Cause (from the deployment source)

  • The crest register lane needs a crest store. cmd/services/sro-gameworld/wiring_authority.go opens one only when SRO_AGENT_MARKS_DIR is set. Without it, crestregister.go:165 refuses every upload ("crest register: no crest store wired").
  • Nothing in the production deployment sets it: neither the GameWorld Nomad job (opensro-ops server-ops/nomad/jobs/gameworld.nomad.hcl) nor apps/server/config/shard-settings.json. So on our shard every crest upload is refused, whatever the file.
  • Even with the store wired, a registered crest never shows over characters until #3451 lands: the client fetches /marks/ without the /api base.

Not yet confirmed against the live process environment: the deployment source is the only input that sets it.

Done when

  • The GameWorld job sets SRO_AGENT_MARKS_DIR to a persistent directory owned by the GameWorld's user that survives releases.
  • #3451 is merged.
  • On the live server, a valid 16×16 crest upload is accepted and shows over a guild member.
主要语言
Go
星标
97
派生
61
平均合并
4 小时 14 分钟
30 天内合并 PR
913

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

opensro-dev/opensro 的其他 Issue

查看 opensro-dev/opensro 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。