guild crest: every upload is refused on our shard (no crest store: SRO_AGENT_MARKS_DIR unset)

Aberta
#3,454 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
Meio dia
Facilidade para iniciantes
25/100
Tipo de issue
Bug
Clareza
Razoavelmente clara
Status de atividade
Ativa
Stack de tecnologia
go

Direção de pesquisa

Start in cmd/services/sro-gameworld/wiring_authority.go, where the crest store opens only when SRO_AGENT_MARKS_DIR is set, and at crestregister.go:165 where uploads are refused. The fix lives in the deployment config: server-ops/nomad/jobs/gameworld.nomad.hcl in the opensro-ops repo, which needs a persistent directory owned by the GameWorld user. Confirm the live process environment first. Done means a valid 16×16 crest upload is accepted and shown over a guild member, and this is blocked until #3451 is merged.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

area: ops bug priority: high

Player report (bug-reports forum, 2026-11-12): the guild crest dialog lets the player pick a .bmp file, but the game does not accept it.

Cause (from the deployment source)

  • The crest register lane needs a crest store. cmd/services/sro-gameworld/wiring_authority.go opens one only when SRO_AGENT_MARKS_DIR is set. Without it, crestregister.go:165 refuses every upload ("crest register: no crest store wired").
  • Nothing in the production deployment sets it: neither the GameWorld Nomad job (opensro-ops server-ops/nomad/jobs/gameworld.nomad.hcl) nor apps/server/config/shard-settings.json. So on our shard every crest upload is refused, whatever the file.
  • Even with the store wired, a registered crest never shows over characters until #3451 lands: the client fetches /marks/ without the /api base.

Not yet confirmed against the live process environment: the deployment source is the only input that sets it.

Done when

  • The GameWorld job sets SRO_AGENT_MARKS_DIR to a persistent directory owned by the GameWorld's user that survives releases.
  • #3451 is merged.
  • On the live server, a valid 16×16 crest upload is accepted and shows over a guild member.
Linguagem predominante
Go
Estrelas
97
Forks
61
Merge médio
4h 14min
PRs com merge (30d)
913

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de opensro-dev/opensro

Todas as issues de opensro-dev/opensro

Issues semelhantes

Mais issues de Go

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.