guild crest: every upload is refused on our shard (no crest store: SRO_AGENT_MARKS_DIR unset)

Abierto
#3,454 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
Medio día
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
go

Línea de trabajo

Start in cmd/services/sro-gameworld/wiring_authority.go, where the crest store opens only when SRO_AGENT_MARKS_DIR is set, and at crestregister.go:165 where uploads are refused. The fix lives in the deployment config: server-ops/nomad/jobs/gameworld.nomad.hcl in the opensro-ops repo, which needs a persistent directory owned by the GameWorld user. Confirm the live process environment first. Done means a valid 16×16 crest upload is accepted and shown over a guild member, and this is blocked until #3451 is merged.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: ops bug priority: high

Player report (bug-reports forum, 2026-11-12): the guild crest dialog lets the player pick a .bmp file, but the game does not accept it.

Cause (from the deployment source)

  • The crest register lane needs a crest store. cmd/services/sro-gameworld/wiring_authority.go opens one only when SRO_AGENT_MARKS_DIR is set. Without it, crestregister.go:165 refuses every upload ("crest register: no crest store wired").
  • Nothing in the production deployment sets it: neither the GameWorld Nomad job (opensro-ops server-ops/nomad/jobs/gameworld.nomad.hcl) nor apps/server/config/shard-settings.json. So on our shard every crest upload is refused, whatever the file.
  • Even with the store wired, a registered crest never shows over characters until #3451 lands: the client fetches /marks/ without the /api base.

Not yet confirmed against the live process environment: the deployment source is the only input that sets it.

Done when

  • The GameWorld job sets SRO_AGENT_MARKS_DIR to a persistent directory owned by the GameWorld's user that survives releases.
  • #3451 is merged.
  • On the live server, a valid 16×16 crest upload is accepted and shows over a guild member.
Lenguaje dominante
Go
Estrellas
97
Forks
61
Merge medio
4 h 14 min
PR fusionados (30 d)
913

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de opensro-dev/opensro

Todos los issues de opensro-dev/opensro

Issues similares

Más issues de Go

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.