Eagerly format default AbortController abort reasons to avoid retaining canceled work
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 48/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- javascript, nodejs
- 领域
- backend
调研方向
Start at the AbortController abort entry point and compare the existing workaround in lib/internal/streams/destroy.js. Reproduce the retention with an .mjs file using node --expose-gc, then verify that default reasons release retained buffers after abort notifications while caller-supplied reasons remain untouched and formatter exceptions do not escape abort().
由索引模型根据 Issue 内容生成。
描述
Could controller.abort() eagerly read the default reason’s stack, following the existing streams workaround and its original discussion?
A retained signal can keep the canceled job alive through signal → reason → V8 stack → caller’s receiver, including large buffers. This surfaced while investigating jsdom window retention.
Run this as an .mjs file with node --expose-gc. Verified on Node v26.8.2, Linux x64:
import { setImmediate } from "node:timers/promises";
class RenderJob {
input = Buffer.alloc(32 * 1024 * 1024, 1);
controller = new AbortController();
cancel() {
this.controller.abort();
return this.controller.signal;
}
}
async function retainedMiB() {
for (let i = 0; i < 5; ++i) {
await setImmediate();
global.gc();
}
return Math.round(process.memoryUsage().arrayBuffers / 1024 ** 2);
}
// Model dependencies retaining signals after the jobs are discarded.
const signals = Array.from({ length: 4 }, () => new RenderJob().cancel());
console.log(await retainedMiB()); // 128
console.log(signals.every(signal => signal.aborted)); // true
for (const signal of signals) void signal.reason.stack;
console.log(await retainedMiB()); // 0
console.log(signals.every(signal => signal.aborted)); // true
The same signals and reasons remain alive throughout; reading their stacks releases all 128 MiB.
I propose formatting only newly created default reasons, leaving caller-supplied reasons untouched. This preserves error identity and stack text with the default formatter. Formatting should follow abort notifications, and formatter exceptions should not escape abort().
GPT-6 Astra Extra High's suggested diff
- abort(reason = new DOMException('This operation was aborted', 'AbortError')) {
- abortSignal(this.#signal ??= new AbortSignal(kDontThrowSymbol), reason);
+ abort(reason = undefined) {
+ const signal = this.#signal ??= new AbortSignal(kDontThrowSymbol);
+ if (signal[kAborted]) return;
+
+ const isDefaultReason = reason === undefined;
+ if (isDefaultReason) {
+ reason = new DOMException('This operation was aborted', 'AbortError');
+ }
+
+ abortSignal(signal, reason);
+
+ if (isDefaultReason) {
+ try {
+ // Release references retained by V8's unformatted stack.
+ // See https://github.com/nodejs/node/pull/34103#issuecomment-652002364
+ reason.stack; // eslint-disable-line no-unused-expressions
+ } catch {
+ // A custom stack formatter must not make cancellation throw.
+ }
+ }
}
The tradeoffs are extra formatting work and earlier Error.prepareStackTrace execution. Custom formatters that retain call sites or throw may still retain the objects. This is the same compromise streams already makes.
Alternately, if the Node.js team has good V8 contacts, it might be good to raise this with them. It's kind of ridiculous for large objects to be retained in this way all because of Error.prepareStackTrace, in my opinion.
- 主要语言
- JavaScript
- 星标
- 122k
- 派生
- 37.4k
- 平均合并
- 4 天 3 小时
- 30 天内合并 PR
- 279
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
nodejs/node 的其他 Issue
-
doc
难度 2/5 1-3 小时 新手友好度 65/100
-
build
难度 1/5 1 小时以内 新手友好度 88/100
-
难度 2/5 1-3 小时 新手友好度 84/100
-
难度 1/5 1 小时以内 新手友好度 90/100
-
feature request
难度 2/5 1-3 小时 新手友好度 68/100
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 75/100
palladius/rails8-app-on-gcp#145 ·
-
难度 2/5 1-3 小时 新手友好度 65/100
dotenvx/dotenv-vscode#139 ·
-
test-change-proposal
难度 2/5 1-3 小时 新手友好度 65/100
web-platform-tests/interop#1455 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
corsairdev/corsair#1764 ·
-
难度 2/5 1-3 小时 新手友好度 75/100