Eagerly format default AbortController abort reasons to avoid retaining canceled work
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 48/100
- issue の種類
- バグ
- 明瞭さ
- おおむね明確
- 活発さ
- 活発
- 技術スタック
- javascript, nodejs
- 領域
- backend
調査の方向性
Start at the AbortController abort entry point and compare the existing workaround in lib/internal/streams/destroy.js. Reproduce the retention with an .mjs file using node --expose-gc, then verify that default reasons release retained buffers after abort notifications while caller-supplied reasons remain untouched and formatter exceptions do not escape abort().
索引モデルが issue の本文から書いたものです。
説明
Could controller.abort() eagerly read the default reason’s stack, following the existing streams workaround and its original discussion?
A retained signal can keep the canceled job alive through signal → reason → V8 stack → caller’s receiver, including large buffers. This surfaced while investigating jsdom window retention.
Run this as an .mjs file with node --expose-gc. Verified on Node v26.8.2, Linux x64:
import { setImmediate } from "node:timers/promises";
class RenderJob {
input = Buffer.alloc(32 * 1024 * 1024, 1);
controller = new AbortController();
cancel() {
this.controller.abort();
return this.controller.signal;
}
}
async function retainedMiB() {
for (let i = 0; i < 5; ++i) {
await setImmediate();
global.gc();
}
return Math.round(process.memoryUsage().arrayBuffers / 1024 ** 2);
}
// Model dependencies retaining signals after the jobs are discarded.
const signals = Array.from({ length: 4 }, () => new RenderJob().cancel());
console.log(await retainedMiB()); // 128
console.log(signals.every(signal => signal.aborted)); // true
for (const signal of signals) void signal.reason.stack;
console.log(await retainedMiB()); // 0
console.log(signals.every(signal => signal.aborted)); // true
The same signals and reasons remain alive throughout; reading their stacks releases all 128 MiB.
I propose formatting only newly created default reasons, leaving caller-supplied reasons untouched. This preserves error identity and stack text with the default formatter. Formatting should follow abort notifications, and formatter exceptions should not escape abort().
GPT-6 Astra Extra High's suggested diff
- abort(reason = new DOMException('This operation was aborted', 'AbortError')) {
- abortSignal(this.#signal ??= new AbortSignal(kDontThrowSymbol), reason);
+ abort(reason = undefined) {
+ const signal = this.#signal ??= new AbortSignal(kDontThrowSymbol);
+ if (signal[kAborted]) return;
+
+ const isDefaultReason = reason === undefined;
+ if (isDefaultReason) {
+ reason = new DOMException('This operation was aborted', 'AbortError');
+ }
+
+ abortSignal(signal, reason);
+
+ if (isDefaultReason) {
+ try {
+ // Release references retained by V8's unformatted stack.
+ // See https://github.com/nodejs/node/pull/34103#issuecomment-652002364
+ reason.stack; // eslint-disable-line no-unused-expressions
+ } catch {
+ // A custom stack formatter must not make cancellation throw.
+ }
+ }
}
The tradeoffs are extra formatting work and earlier Error.prepareStackTrace execution. Custom formatters that retain call sites or throw may still retain the objects. This is the same compromise streams already makes.
Alternately, if the Node.js team has good V8 contacts, it might be good to raise this with them. It's kind of ridiculous for large objects to be retained in this way all because of Error.prepareStackTrace, in my opinion.
- 主要言語
- JavaScript
- スター
- 122k
- フォーク
- 37.4k
- 平均マージ
- 4日 3時間
- マージ済み PR(30日)
- 279
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
nodejs/node のほかの issue
-
doc
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
-
build
難易度 1/5 1時間未満 初心者へのやさしさ 88/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 84/100
-
難易度 1/5 1時間未満 初心者へのやさしさ 90/100
-
feature request
難易度 2/5 1〜3時間 初心者へのやさしさ 68/100
似ている issue
-
bug customer-eng Durable Agents Inngest status: needs triage
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
-
optimization optimization:agents-md-curator
難易度 2/5 1〜3時間 初心者へのやさしさ 75/100
githubnext/gh-aw-cao#13475 ·
-
[BUG]: "Clear All" in Settings doesn't clear the saved analysis, old data comes back after reload オープンbug
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
AOSSIE-Org/OrgExplorer#253 · コメント 1 件 ·
-
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
oxc-project/oxc#26944 ·
-
ai-observability bug team/ai-observability
難易度 2/5 1〜3時間 初心者へのやさしさ 78/100