Eagerly format default AbortController abort reasons to avoid retaining canceled work
Ninguém assumiu esta issue ainda.
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 48/100
- Tipo de issue
- Bug
- Clareza
- Razoavelmente clara
- Status de atividade
- Ativa
- Stack de tecnologia
- javascript, nodejs
- Domínio
- backend
Direção de pesquisa
Start at the AbortController abort entry point and compare the existing workaround in lib/internal/streams/destroy.js. Reproduce the retention with an .mjs file using node --expose-gc, then verify that default reasons release retained buffers after abort notifications while caller-supplied reasons remain untouched and formatter exceptions do not escape abort().
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Could controller.abort() eagerly read the default reason’s stack, following the existing streams workaround and its original discussion?
A retained signal can keep the canceled job alive through signal → reason → V8 stack → caller’s receiver, including large buffers. This surfaced while investigating jsdom window retention.
Run this as an .mjs file with node --expose-gc. Verified on Node v26.8.2, Linux x64:
import { setImmediate } from "node:timers/promises";
class RenderJob {
input = Buffer.alloc(32 * 1024 * 1024, 1);
controller = new AbortController();
cancel() {
this.controller.abort();
return this.controller.signal;
}
}
async function retainedMiB() {
for (let i = 0; i < 5; ++i) {
await setImmediate();
global.gc();
}
return Math.round(process.memoryUsage().arrayBuffers / 1024 ** 2);
}
// Model dependencies retaining signals after the jobs are discarded.
const signals = Array.from({ length: 4 }, () => new RenderJob().cancel());
console.log(await retainedMiB()); // 128
console.log(signals.every(signal => signal.aborted)); // true
for (const signal of signals) void signal.reason.stack;
console.log(await retainedMiB()); // 0
console.log(signals.every(signal => signal.aborted)); // true
The same signals and reasons remain alive throughout; reading their stacks releases all 128 MiB.
I propose formatting only newly created default reasons, leaving caller-supplied reasons untouched. This preserves error identity and stack text with the default formatter. Formatting should follow abort notifications, and formatter exceptions should not escape abort().
GPT-6 Astra Extra High's suggested diff
- abort(reason = new DOMException('This operation was aborted', 'AbortError')) {
- abortSignal(this.#signal ??= new AbortSignal(kDontThrowSymbol), reason);
+ abort(reason = undefined) {
+ const signal = this.#signal ??= new AbortSignal(kDontThrowSymbol);
+ if (signal[kAborted]) return;
+
+ const isDefaultReason = reason === undefined;
+ if (isDefaultReason) {
+ reason = new DOMException('This operation was aborted', 'AbortError');
+ }
+
+ abortSignal(signal, reason);
+
+ if (isDefaultReason) {
+ try {
+ // Release references retained by V8's unformatted stack.
+ // See https://github.com/nodejs/node/pull/34103#issuecomment-652002364
+ reason.stack; // eslint-disable-line no-unused-expressions
+ } catch {
+ // A custom stack formatter must not make cancellation throw.
+ }
+ }
}
The tradeoffs are extra formatting work and earlier Error.prepareStackTrace execution. Custom formatters that retain call sites or throw may still retain the objects. This is the same compromise streams already makes.
Alternately, if the Node.js team has good V8 contacts, it might be good to raise this with them. It's kind of ridiculous for large objects to be retained in this way all because of Error.prepareStackTrace, in my opinion.
- Linguagem predominante
- JavaScript
- Estrelas
- 122k
- Forks
- 37.4k
- Merge médio
- 4d 3h
- PRs com merge (30d)
- 279
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de nodejs/node
-
doc
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 65/100
-
build
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 88/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 84/100
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 90/100
-
feature request
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
Todas as issues de nodejs/node
Issues semelhantes
-
bug confirmed issue
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
open-webui/open-webui#30750 · 1 comentário ·
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
-
Mend: dependency security vulnerability untriaged
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 70/100