chore(web): enforce test cleanup and the CSS reset rule in code, fix dependency placement

未关闭
  • 哪里不对？
#429 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
78/100
Issue 类型
重构
描述清晰度
描述清楚
活跃度
活跃
技术栈
css, typescript
领域
frontend, testing

调研方向

Start with src/journal.css, src/test/setup.ts, and vite.config.ts; inspect the existing reset comments, PrefsContext cleanup, and vi.clearAllMocks() calls. Move the stated DOM cleanup into a global afterEach, enable clearMocks, and remove duplicate cleanup. Run the listed lint, type-check, coverage, build, and shuffled test commands; done when they pass with at least 80% coverage and no app behavior change.

由索引模型根据 Issue 内容生成。

描述

tech-debt

Found while trimming TaskFlow.Web/CLAUDE.md for #400. Each rule in that file that Claude cannot read from the code is better enforced in the code, so the prose can go.

Scope

  1. Add a comment on the .journal-page button reset in src/journal.css (specificity 0-1-1) saying that a button needing its own border or background must be scoped as .journal-page .classname (0-2-0). Four later rules already carry this comment; the reset itself has none.

  2. Move the PrefsContext DOM cleanup into src/test/setup.ts as a global afterEach: document.documentElement.removeAttribute('data-theme'), document.documentElement.classList.remove('is-dark'), localStorage.clear(). Remove the same cleanup from tests that now duplicate it.

  3. Set clearMocks: true in the vitest config in vite.config.ts, and drop the vi.clearAllMocks() calls in beforeEach that it makes redundant.

  4. Move clsx, tailwind-merge and class-variance-authority from devDependencies to dependencies in TaskFlow.Web/package.json, and refresh package-lock.json. src/lib/utils.ts imports clsx and tailwind-merge in production code (the app works because Vite bundles them); check whether class-variance-authority is imported at all and remove it if it is unused.

Acceptance criteria

  1. npm run lint, npm run type-check, npm run test -- --run --coverage and npm run build pass, and coverage stays at or above 80%.
  2. The full test suite passes in a random order (--sequence.shuffle), to show the global cleanup removed the need for per-file cleanup.
  3. No behaviour change in the app.
  4. Every package imported from src/** (not tests) is listed under dependencies, not devDependencies.

Out of scope

The status casing bridge (src/lib/task-status.ts); see #428.

主要语言
C#
星标
1
派生
0
平均合并
2 小时 2 分钟
30 天内合并 PR
98

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

nevridge/TaskFlow 的其他 Issue

查看 nevridge/TaskFlow 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。