chore(web): enforce test cleanup and the CSS reset rule in code, fix dependency placement

Abierto
  • ¿Algo no está bien?
#429 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
78/100
Tipo de issue
Refactorización
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
css, typescript
Área
frontend, testing

Línea de trabajo

Start with src/journal.css, src/test/setup.ts, and vite.config.ts; inspect the existing reset comments, PrefsContext cleanup, and vi.clearAllMocks() calls. Move the stated DOM cleanup into a global afterEach, enable clearMocks, and remove duplicate cleanup. Run the listed lint, type-check, coverage, build, and shuffled test commands; done when they pass with at least 80% coverage and no app behavior change.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

tech-debt

Found while trimming TaskFlow.Web/CLAUDE.md for #400. Each rule in that file that Claude cannot read from the code is better enforced in the code, so the prose can go.

Scope

  1. Add a comment on the .journal-page button reset in src/journal.css (specificity 0-1-1) saying that a button needing its own border or background must be scoped as .journal-page .classname (0-2-0). Four later rules already carry this comment; the reset itself has none.

  2. Move the PrefsContext DOM cleanup into src/test/setup.ts as a global afterEach: document.documentElement.removeAttribute('data-theme'), document.documentElement.classList.remove('is-dark'), localStorage.clear(). Remove the same cleanup from tests that now duplicate it.

  3. Set clearMocks: true in the vitest config in vite.config.ts, and drop the vi.clearAllMocks() calls in beforeEach that it makes redundant.

  4. Move clsx, tailwind-merge and class-variance-authority from devDependencies to dependencies in TaskFlow.Web/package.json, and refresh package-lock.json. src/lib/utils.ts imports clsx and tailwind-merge in production code (the app works because Vite bundles them); check whether class-variance-authority is imported at all and remove it if it is unused.

Acceptance criteria

  1. npm run lint, npm run type-check, npm run test -- --run --coverage and npm run build pass, and coverage stays at or above 80%.
  2. The full test suite passes in a random order (--sequence.shuffle), to show the global cleanup removed the need for per-file cleanup.
  3. No behaviour change in the app.
  4. Every package imported from src/** (not tests) is listed under dependencies, not devDependencies.

Out of scope

The status casing bridge (src/lib/task-status.ts); see #428.

Lenguaje dominante
C#
Estrellas
1
Forks
0
Merge medio
2 h 2 min
PR fusionados (30 d)
98

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de nevridge/TaskFlow

Todos los issues de nevridge/TaskFlow

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.