chore(web): enforce test cleanup and the CSS reset rule in code, fix dependency placement

Aperta
  • Qualcosa non va?
#429 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
78/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
css, typescript
Ambito
frontend, testing

Direzione di ricerca

Start with src/journal.css, src/test/setup.ts, and vite.config.ts; inspect the existing reset comments, PrefsContext cleanup, and vi.clearAllMocks() calls. Move the stated DOM cleanup into a global afterEach, enable clearMocks, and remove duplicate cleanup. Run the listed lint, type-check, coverage, build, and shuffled test commands; done when they pass with at least 80% coverage and no app behavior change.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

tech-debt

Found while trimming TaskFlow.Web/CLAUDE.md for #400. Each rule in that file that Claude cannot read from the code is better enforced in the code, so the prose can go.

Scope

  1. Add a comment on the .journal-page button reset in src/journal.css (specificity 0-1-1) saying that a button needing its own border or background must be scoped as .journal-page .classname (0-2-0). Four later rules already carry this comment; the reset itself has none.

  2. Move the PrefsContext DOM cleanup into src/test/setup.ts as a global afterEach: document.documentElement.removeAttribute('data-theme'), document.documentElement.classList.remove('is-dark'), localStorage.clear(). Remove the same cleanup from tests that now duplicate it.

  3. Set clearMocks: true in the vitest config in vite.config.ts, and drop the vi.clearAllMocks() calls in beforeEach that it makes redundant.

  4. Move clsx, tailwind-merge and class-variance-authority from devDependencies to dependencies in TaskFlow.Web/package.json, and refresh package-lock.json. src/lib/utils.ts imports clsx and tailwind-merge in production code (the app works because Vite bundles them); check whether class-variance-authority is imported at all and remove it if it is unused.

Acceptance criteria

  1. npm run lint, npm run type-check, npm run test -- --run --coverage and npm run build pass, and coverage stays at or above 80%.
  2. The full test suite passes in a random order (--sequence.shuffle), to show the global cleanup removed the need for per-file cleanup.
  3. No behaviour change in the app.
  4. Every package imported from src/** (not tests) is listed under dependencies, not devDependencies.

Out of scope

The status casing bridge (src/lib/task-status.ts); see #428.

Lingua principale
C#
Stelle
1
Fork
0
Merge medio
2h 2m
PR unite (30g)
98

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di nevridge/TaskFlow

Tutte le issue di nevridge/TaskFlow

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.