`inlineVariables.exclude` rejects a list declared `as const`

未关闭 适合新手
#561 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 5 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
84/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
react-native, typescript

调研方向

阅读 src/compiler/compiler.types.ts,查看 InlineVariableOptions.exclude 的类型;再阅读 src/compiler/compiler.ts,了解 exclusionList 如何使用它。Issue 中包含一个位于 src/__tests__/compiler/inline-variables-exclude.test.ts 的 TypeScript 编译器测试;运行该测试以确认失败,然后验证 as const 示例能通过类型检查,且现有的排除行为仍然有效。

由索引模型根据 Issue 内容生成。

描述

Before submitting a new issue
  • I tested using the latest version of the library, as the bug might be already fixed.
  • I tested using a supported version of react native.
  • I checked for possible duplicate issues, with possible answers.
Bug summary

InlineVariableOptions.exclude in src/compiler/compiler.types.ts is `--${string}`[], a mutable array, so a list declared as const fails to type-check, while compile() only calls .includes on it (src/compiler/compiler.ts, exclusionList).

Library version

main at df32ce3

Environment info
System:
  OS: Windows 11 10.0.26300
  CPU: "(32) x64 AMD Ryzen 9 9950X3D 16-Core Processor          "
  Memory: 160.57 GB / 255.67 GB
Binaries:
  Node:
    version: 26.12.1
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 4.9.2
    path: C:\Users\<user>\AppData\Roaming\npm\yarn.CMD
  npm:
    version: 12.2.1
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK:
    AllowDevelopmentWithoutDevLicense: Enabled
    Versions:
      - 10.0.19041.0
      - 10.0.26100.0
IDEs:
  Android Studio: AI-262.9437.185.2621.16467767
  Visual Studio: Not Found
Languages:
  Java:
    version: 17.0.20.1
    path: C:\Program Files\Microsoft\jdk-17.0.20.101-hotspot\bin\javac.EXE
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 19.2.3
    wanted: 19.2.3
  react-native:
    installed: 0.86.3
    wanted: 0.86.3
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found
Steps to reproduce
  1. Clone the reproducer branch, which is main at df32ce3 with one file added, src/__tests__/compiler/inline-variables-exclude.test.ts, and install:
    git clone --branch repro/inline-variables-exclude-readonly https://github.com/YevheniiKotyrlo/react-native-css
    cd react-native-css
    yarn install
    
  2. Run yarn test src/__tests__/compiler/inline-variables-exclude.test.ts.

src/__tests__/compiler/inline-variables-exclude.test.ts:

import { join } from "node:path";

import ts from "typescript";

const root = join(__dirname, "../../..").replaceAll("\\", "/");
const fixtureName = `${root}/src/__tests__/compiler/inline-variables-exclude.fixture.ts`;

function diagnostics(text: string): readonly string[] {
  const { config } = ts.readConfigFile(`${root}/tsconfig.json`, (path) =>
    ts.sys.readFile(path),
  );
  const { options } = ts.parseJsonConfigFileContent(config, ts.sys, root);
  const host = ts.createCompilerHost(options, true);
  const program = ts.createProgram([fixtureName], options, {
    ...host,
    getCurrentDirectory: () => root,
    fileExists: (name) => name === fixtureName || host.fileExists(name),
    readFile: (name) => (name === fixtureName ? text : host.readFile(name)),
    getSourceFile: (name, languageVersion, ...rest) =>
      name === fixtureName
        ? ts.createSourceFile(name, text, languageVersion, true)
        : host.getSourceFile(name, languageVersion, ...rest),
  });
  return ts
    .getPreEmitDiagnostics(program, program.getSourceFile(fixtureName))
    .map(({ messageText }) =>
      ts.flattenDiagnosticMessageText(messageText, "\n"),
    );
}

test("inlineVariables.exclude takes a list declared as const", () => {
  expect(
    diagnostics(
      [
        `import { compile } from "react-native-css/compiler";`,
        `const preserved = ["--brand", "--accent"] as const;`,
        `compile(":root { --brand: red; }", { inlineVariables: { exclude: preserved } });`,
      ].join("\n"),
    ),
  ).toStrictEqual([]);
});

Expected: the snippet compiles.

Actual: The type 'readonly ["--brand", "--accent"]' is 'readonly' and cannot be assigned to the mutable type '`--${string}`[]'.

The run's output on main at df32ce3, Windows 11, Node 26.12.1
FAIL src/__tests__/compiler/inline-variables-exclude.test.ts (29.866 s)
  × inlineVariables.exclude takes a list declared as const (1095 ms)
  ● inlineVariables.exclude takes a list declared as const
    expect(received).toStrictEqual(expected) // deep equality
    - Expected  - 1
    + Received  + 3
    - Array []
    + Array [
    +   "The type 'readonly [\"--brand\", \"--accent\"]' is 'readonly' and cannot be assigned to the mutable type '`--${string}`[]'.",
    + ]
Test Suites: 1 failed, 1 total
Tests:       1 failed, 1 total
Reproducible example repository

https://github.com/YevheniiKotyrlo/react-native-css/tree/repro/inline-variables-exclude-readonly

主要语言
TypeScript
星标
166
派生
45
平均合并
10 天 1 小时
30 天内合并 PR
4

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

nativewind/react-native-css 的其他 Issue

查看 nativewind/react-native-css 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。