`inlineVariables.exclude` rejects a list declared `as const`

未關閉 適合新手
  • 哪裡不對？
#561 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 5 天內回覆

還沒有人認領這個 Issue。

評估

難度
2/5
預估耗時
1-3 小時
新手友好度
84/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
react-native, typescript
領域
developer-experience

研究方向

閱讀 src/compiler/compiler.types.ts，查看 InlineVariableOptions.exclude 的型別；再閱讀 src/compiler/compiler.ts，了解 exclusionList 如何使用它。Issue 中包含一個位於 src/__tests__/compiler/inline-variables-exclude.test.ts 的 TypeScript 編譯器測試；執行該測試以確認失敗，然後驗證 as const 範例能通過型別檢查，且現有的排除行為仍然有效。

由索引模型根據 Issue 內容生成。

描述

Before submitting a new issue
  • I tested using the latest version of the library, as the bug might be already fixed.
  • I tested using a supported version of react native.
  • I checked for possible duplicate issues, with possible answers.
Bug summary

InlineVariableOptions.exclude in src/compiler/compiler.types.ts is `--${string}`[], a mutable array, so a list declared as const fails to type-check, while compile() only calls .includes on it (src/compiler/compiler.ts, exclusionList).

Library version

main at df32ce3

Environment info
System:
  OS: Windows 11 10.0.26300
  CPU: "(32) x64 AMD Ryzen 9 9950X3D 16-Core Processor          "
  Memory: 160.57 GB / 255.67 GB
Binaries:
  Node:
    version: 26.12.1
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 4.9.2
    path: C:\Users\<user>\AppData\Roaming\npm\yarn.CMD
  npm:
    version: 12.2.1
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK:
    AllowDevelopmentWithoutDevLicense: Enabled
    Versions:
      - 10.0.19041.0
      - 10.0.26100.0
IDEs:
  Android Studio: AI-262.9437.185.2621.16467767
  Visual Studio: Not Found
Languages:
  Java:
    version: 17.0.20.1
    path: C:\Program Files\Microsoft\jdk-17.0.20.101-hotspot\bin\javac.EXE
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 19.2.3
    wanted: 19.2.3
  react-native:
    installed: 0.86.3
    wanted: 0.86.3
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found
Steps to reproduce
  1. Clone the reproducer branch, which is main at df32ce3 with one file added, src/__tests__/compiler/inline-variables-exclude.test.ts, and install: 
    git clone --branch repro/inline-variables-exclude-readonly https://github.com/YevheniiKotyrlo/react-native-css
cd react-native-css
yarn install
  2. Run yarn test src/__tests__/compiler/inline-variables-exclude.test.ts.

src/__tests__/compiler/inline-variables-exclude.test.ts:

import { join } from "node:path";

import ts from "typescript";

const root = join(__dirname, "../../..").replaceAll("\\", "/");
const fixtureName = `${root}/src/__tests__/compiler/inline-variables-exclude.fixture.ts`;

function diagnostics(text: string): readonly string[] {
  const { config } = ts.readConfigFile(`${root}/tsconfig.json`, (path) =>
    ts.sys.readFile(path),
  );
  const { options } = ts.parseJsonConfigFileContent(config, ts.sys, root);
  const host = ts.createCompilerHost(options, true);
  const program = ts.createProgram([fixtureName], options, {
    ...host,
    getCurrentDirectory: () => root,
    fileExists: (name) => name === fixtureName || host.fileExists(name),
    readFile: (name) => (name === fixtureName ? text : host.readFile(name)),
    getSourceFile: (name, languageVersion, ...rest) =>
      name === fixtureName
        ? ts.createSourceFile(name, text, languageVersion, true)
        : host.getSourceFile(name, languageVersion, ...rest),
  });
  return ts
    .getPreEmitDiagnostics(program, program.getSourceFile(fixtureName))
    .map(({ messageText }) =>
      ts.flattenDiagnosticMessageText(messageText, "\n"),
    );
}

test("inlineVariables.exclude takes a list declared as const", () => {
  expect(
    diagnostics(
      [
        `import { compile } from "react-native-css/compiler";`,
        `const preserved = ["--brand", "--accent"] as const;`,
        `compile(":root { --brand: red; }", { inlineVariables: { exclude: preserved } });`,
      ].join("\n"),
    ),
  ).toStrictEqual([]);
});

Expected: the snippet compiles.

Actual: The type 'readonly ["--brand", "--accent"]' is 'readonly' and cannot be assigned to the mutable type '`--${string}`[]'.

The run's output on main at df32ce3, Windows 11, Node 26.12.1 
FAIL src/__tests__/compiler/inline-variables-exclude.test.ts (29.866 s)
  × inlineVariables.exclude takes a list declared as const (1095 ms)
  ● inlineVariables.exclude takes a list declared as const
    expect(received).toStrictEqual(expected) // deep equality
    - Expected  - 1
    + Received  + 3
    - Array []
    + Array [
    +   "The type 'readonly [\"--brand\", \"--accent\"]' is 'readonly' and cannot be assigned to the mutable type '`--${string}`[]'.",
    + ]
Test Suites: 1 failed, 1 total
Tests:       1 failed, 1 total
Reproducible example repository

https://github.com/YevheniiKotyrlo/react-native-css/tree/repro/inline-variables-exclude-readonly

主要語言
TypeScript
星號
166
分支
45
平均合併
10 天 1 小時
30 天內合併 PR
4

環境準備

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

nativewind/react-native-css 的其他 Issue

查看 nativewind/react-native-css 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。