`styled()` takes a `null` or `false` mapping entry, a `null` mapping and a string `nativeStyleMapping` without its `Invalid mapping` error

未关闭 适合新手
  • 哪里不对？
#559 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 5 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
78/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
react-native, typescript
领域
frontend

调研方向

从 src/native/react/useNativeCss.ts 入手，这里 mappingToConfig 会构建原生样式映射，并参考 src/__tests__/native/styled-invalid-mapping.test.tsx 中的复现用例。检查 null 和 false 条目、null 映射以及字符串类型的 nativeStyleMapping 是如何验证的。每种情况都抛出预期的 styled(): Invalid mapping for className 错误即表示完成。

由索引模型根据 Issue 内容生成。

描述

Before submitting a new issue
  • I tested using the latest version of the library, as the bug might be already fixed.
  • I tested using a supported version of react native.
  • I checked for possible duplicate issues, with possible answers.
Bug summary

mappingToConfig in src/native/react/useNativeCss.ts throws styled(): Invalid mapping for ${key}: ${value} for a value it cannot map, but typeof value === "object" admits null, and the native style mapping it builds keeps any entry and takes a string's characters as entries. The types reject each value below, so it is what JavaScript or an any passes: an entry of null or false reaches path.split(".") in the native style mapping at render, a null mapping throws a TypeError from styled(), and a string nativeStyleMapping maps nothing.

#323, for #288 and #348, maps a true entry to its key.

Library version

main at df32ce3

Environment info
System:
  OS: Windows 11 10.0.26300
  CPU: "(32) x64 AMD Ryzen 9 9950X3D 16-Core Processor          "
  Memory: 160.57 GB / 255.67 GB
Binaries:
  Node:
    version: 26.12.1
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 4.9.2
    path: C:\Users\<user>\AppData\Roaming\npm\yarn.CMD
  npm:
    version: 12.2.1
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK:
    AllowDevelopmentWithoutDevLicense: Enabled
    Versions:
      - 10.0.19041.0
      - 10.0.26100.0
IDEs:
  Android Studio: AI-262.9437.185.2621.16467767
  Visual Studio: Not Found
Languages:
  Java:
    version: 17.0.20.1
    path: C:\Program Files\Microsoft\jdk-17.0.20.101-hotspot\bin\javac.EXE
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 19.2.3
    wanted: 19.2.3
  react-native:
    installed: 0.86.3
    wanted: 0.86.3
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found
Steps to reproduce
  1. Clone the reproducer branch, which is main at df32ce3 with one file added, src/__tests__/native/styled-invalid-mapping.test.tsx, and install: 
    git clone --branch repro/styled-mapping-invalid-values https://github.com/YevheniiKotyrlo/react-native-css
cd react-native-css
yarn install
  2. Run yarn test src/__tests__/native/styled-invalid-mapping.test.tsx.

src/__tests__/native/styled-invalid-mapping.test.tsx:

import { View } from "react-native";

import { styled } from "react-native-css";

test.each([
  [
    "an entry set to null",
    { className: { target: "style", nativeStyleMapping: { color: null } } },
  ],
  [
    "an entry set to false",
    { className: { target: "style", nativeStyleMapping: { color: false } } },
  ],
  ["a mapping set to null", { className: null }],
  [
    "a nativeStyleMapping set to a string",
    {
      className: { target: "style", nativeStyleMapping: "accessibilityLabel" },
    },
  ],
])("%s fails at styled() with its Invalid mapping error", (_, mapping) => {
  expect(() => styled(View, mapping as never)).toThrow(
    "styled(): Invalid mapping for className",
  );
});

Expected: styled() fails with its styled(): Invalid mapping for className error for each value.

Actual: it throws nothing for three of them, and Cannot read properties of null (reading 'nativeStyleMapping') for the null mapping.

The run's output on main at df32ce3, Windows 11, Node 26.12.1 
FAIL src/__tests__/native/styled-invalid-mapping.test.tsx (10.623 s)
  × an entry set to null fails at styled() with its Invalid mapping error (2 ms)
  × an entry set to false fails at styled() with its Invalid mapping error (1 ms)
  × a mapping set to null fails at styled() with its Invalid mapping error (11 ms)
  × a nativeStyleMapping set to a string fails at styled() with its Invalid mapping error
  ● an entry set to null fails at styled() with its Invalid mapping error
    Expected substring: "styled(): Invalid mapping for className"
    Received function did not throw
  ● an entry set to false fails at styled() with its Invalid mapping error
    Expected substring: "styled(): Invalid mapping for className"
    Received function did not throw
  ● a mapping set to null fails at styled() with its Invalid mapping error
    Expected substring: "styled(): Invalid mapping for className"
    Received message:   "Cannot read properties of null (reading 'nativeStyleMapping')"
  ● a nativeStyleMapping set to a string fails at styled() with its Invalid mapping error
    Expected substring: "styled(): Invalid mapping for className"
    Received function did not throw
Test Suites: 1 failed, 1 total
Tests:       4 failed, 4 total
Reproducible example repository

https://github.com/YevheniiKotyrlo/react-native-css/tree/repro/styled-mapping-invalid-values

主要语言
TypeScript
星标
166
派生
45
平均合并
10 天 1 小时
30 天内合并 PR
4

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

nativewind/react-native-css 的其他 Issue

查看 nativewind/react-native-css 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。