`styled()` takes a `null` or `false` mapping entry, a `null` mapping and a string `nativeStyleMapping` without its `Invalid mapping` error

Aberta Para iniciantes
  • Algo errado?
#559 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 5 dias

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
78/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
react-native, typescript
Domínio
frontend

Direção de pesquisa

Comece por src/native/react/useNativeCss.ts, onde mappingToConfig cria o mapeamento de estilos nativos, e use como guia os casos de reprodução em src/__tests__/native/styled-invalid-mapping.test.tsx. Verifique como são validadas entradas null e false, um mapeamento null e um nativeStyleMapping do tipo string. O trabalho estará concluído quando cada caso lançar o erro esperado styled(): Invalid mapping for className.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Before submitting a new issue
  • I tested using the latest version of the library, as the bug might be already fixed.
  • I tested using a supported version of react native.
  • I checked for possible duplicate issues, with possible answers.
Bug summary

mappingToConfig in src/native/react/useNativeCss.ts throws styled(): Invalid mapping for ${key}: ${value} for a value it cannot map, but typeof value === "object" admits null, and the native style mapping it builds keeps any entry and takes a string's characters as entries. The types reject each value below, so it is what JavaScript or an any passes: an entry of null or false reaches path.split(".") in the native style mapping at render, a null mapping throws a TypeError from styled(), and a string nativeStyleMapping maps nothing.

#323, for #288 and #348, maps a true entry to its key.

Library version

main at df32ce3

Environment info
System:
  OS: Windows 11 10.0.26300
  CPU: "(32) x64 AMD Ryzen 9 9950X3D 16-Core Processor          "
  Memory: 160.57 GB / 255.67 GB
Binaries:
  Node:
    version: 26.12.1
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 4.9.2
    path: C:\Users\<user>\AppData\Roaming\npm\yarn.CMD
  npm:
    version: 12.2.1
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK:
    AllowDevelopmentWithoutDevLicense: Enabled
    Versions:
      - 10.0.19041.0
      - 10.0.26100.0
IDEs:
  Android Studio: AI-262.9437.185.2621.16467767
  Visual Studio: Not Found
Languages:
  Java:
    version: 17.0.20.1
    path: C:\Program Files\Microsoft\jdk-17.0.20.101-hotspot\bin\javac.EXE
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 19.2.3
    wanted: 19.2.3
  react-native:
    installed: 0.86.3
    wanted: 0.86.3
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found
Steps to reproduce
  1. Clone the reproducer branch, which is main at df32ce3 with one file added, src/__tests__/native/styled-invalid-mapping.test.tsx, and install: 
    git clone --branch repro/styled-mapping-invalid-values https://github.com/YevheniiKotyrlo/react-native-css
cd react-native-css
yarn install
  2. Run yarn test src/__tests__/native/styled-invalid-mapping.test.tsx.

src/__tests__/native/styled-invalid-mapping.test.tsx:

import { View } from "react-native";

import { styled } from "react-native-css";

test.each([
  [
    "an entry set to null",
    { className: { target: "style", nativeStyleMapping: { color: null } } },
  ],
  [
    "an entry set to false",
    { className: { target: "style", nativeStyleMapping: { color: false } } },
  ],
  ["a mapping set to null", { className: null }],
  [
    "a nativeStyleMapping set to a string",
    {
      className: { target: "style", nativeStyleMapping: "accessibilityLabel" },
    },
  ],
])("%s fails at styled() with its Invalid mapping error", (_, mapping) => {
  expect(() => styled(View, mapping as never)).toThrow(
    "styled(): Invalid mapping for className",
  );
});

Expected: styled() fails with its styled(): Invalid mapping for className error for each value.

Actual: it throws nothing for three of them, and Cannot read properties of null (reading 'nativeStyleMapping') for the null mapping.

The run's output on main at df32ce3, Windows 11, Node 26.12.1 
FAIL src/__tests__/native/styled-invalid-mapping.test.tsx (10.623 s)
  × an entry set to null fails at styled() with its Invalid mapping error (2 ms)
  × an entry set to false fails at styled() with its Invalid mapping error (1 ms)
  × a mapping set to null fails at styled() with its Invalid mapping error (11 ms)
  × a nativeStyleMapping set to a string fails at styled() with its Invalid mapping error
  ● an entry set to null fails at styled() with its Invalid mapping error
    Expected substring: "styled(): Invalid mapping for className"
    Received function did not throw
  ● an entry set to false fails at styled() with its Invalid mapping error
    Expected substring: "styled(): Invalid mapping for className"
    Received function did not throw
  ● a mapping set to null fails at styled() with its Invalid mapping error
    Expected substring: "styled(): Invalid mapping for className"
    Received message:   "Cannot read properties of null (reading 'nativeStyleMapping')"
  ● a nativeStyleMapping set to a string fails at styled() with its Invalid mapping error
    Expected substring: "styled(): Invalid mapping for className"
    Received function did not throw
Test Suites: 1 failed, 1 total
Tests:       4 failed, 4 total
Reproducible example repository

https://github.com/YevheniiKotyrlo/react-native-css/tree/repro/styled-mapping-invalid-values

Linguagem predominante
TypeScript
Estrelas
166
Forks
45
Merge médio
10d 1h
PRs com merge (30d)
4

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de nativewind/react-native-css

Todas as issues de nativewind/react-native-css

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.