Don't connect dots unless they are adjacent in the data

未关闭
  • 哪里不对？
#339 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 8 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
javascript
领域
data-visualization

调研方向

Start with the Top Languages chart and trace how observations are converted into plotted lines. Check how dates are represented and identify where nonconsecutive observations are connected. Done means points separated by missing dates remain separate, while lines still connect observations for consecutive dates.

由索引模型根据 Issue 内容生成。

描述

This is a rare issue that can make affected charts somewhat confusing. Imagine that a particular population is only in the data on two days: January 1, 2017 and January 1, 2019. Ensemble will show a line connecting those two points, even though that population isn't actually in the dataset for most of that time.

This can happen on the Top Languages chart. The chart shows only the top 5 languages. For some time, zh-CN and es-ES were fighting for 5th place. zh-CN overtook es-ES exactly twice: once in December 2018 and once in April 2019. It wasn't in 5th place in January, February, or March. Nonetheless, Ensemble drew a line between December 2018 and April 2019 for zh-CN, implying that it was one of the top 5 languages that whole time when it was not.

Screen Shot 2019-08-19 at 6 32 02 PM

One solution might be to show separate dots in these situations and only draw lines between dots that represent consecutive dates in the dataset.

主要语言
JavaScript
星标
21
派生
7
平均合并
7 天 6 小时
30 天内合并 PR
5

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

mozilla/ensemble 的其他 Issue

查看 mozilla/ensemble 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。