Don't connect dots unless they are adjacent in the data

Abierto
#339 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 8 días

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Estancado
Stack tecnológico
javascript

Línea de trabajo

Start with the Top Languages chart and trace how observations are converted into plotted lines. Check how dates are represented and identify where nonconsecutive observations are connected. Done means points separated by missing dates remain separate, while lines still connect observations for consecutive dates.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

This is a rare issue that can make affected charts somewhat confusing. Imagine that a particular population is only in the data on two days: January 1, 2017 and January 1, 2019. Ensemble will show a line connecting those two points, even though that population isn't actually in the dataset for most of that time.

This can happen on the Top Languages chart. The chart shows only the top 5 languages. For some time, zh-CN and es-ES were fighting for 5th place. zh-CN overtook es-ES exactly twice: once in December 2018 and once in April 2019. It wasn't in 5th place in January, February, or March. Nonetheless, Ensemble drew a line between December 2018 and April 2019 for zh-CN, implying that it was one of the top 5 languages that whole time when it was not.

Screen Shot 2019-08-19 at 6 32 02 PM

One solution might be to show separate dots in these situations and only draw lines between dots that represent consecutive dates in the dataset.

Lenguaje dominante
JavaScript
Estrellas
21
Forks
7
Merge medio
7 d 6 h
PR fusionados (30 d)
5

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de mozilla/ensemble

Todos los issues de mozilla/ensemble

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.