Don't connect dots unless they are adjacent in the data

Aperta
#339 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 8 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Ferma
Stack tecnologico
javascript

Direzione di ricerca

Start with the Top Languages chart and trace how observations are converted into plotted lines. Check how dates are represented and identify where nonconsecutive observations are connected. Done means points separated by missing dates remain separate, while lines still connect observations for consecutive dates.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

This is a rare issue that can make affected charts somewhat confusing. Imagine that a particular population is only in the data on two days: January 1, 2017 and January 1, 2019. Ensemble will show a line connecting those two points, even though that population isn't actually in the dataset for most of that time.

This can happen on the Top Languages chart. The chart shows only the top 5 languages. For some time, zh-CN and es-ES were fighting for 5th place. zh-CN overtook es-ES exactly twice: once in December 2018 and once in April 2019. It wasn't in 5th place in January, February, or March. Nonetheless, Ensemble drew a line between December 2018 and April 2019 for zh-CN, implying that it was one of the top 5 languages that whole time when it was not.

Screen Shot 2019-08-19 at 6 32 02 PM

One solution might be to show separate dots in these situations and only draw lines between dots that represent consecutive dates in the dataset.

Lingua principale
JavaScript
Stelle
21
Fork
7
Merge medio
7g 6h
PR unite (30g)
5

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di mozilla/ensemble

Tutte le issue di mozilla/ensemble

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.