[meta] revisit scopes
还没有人认领这个 Issue。
评估
调研方向
审查所有脚本中的 scope 处理方式,从 scriptworker.constants.DEFAULT_CONFIG.cot_restricted_scopes 以及 issue 中描述的 task.payload 数据开始。将 signing 和其他脚本的行为与 restricted-scope 模式进行比较。当受限设置仍然作为 scopes 保留,而其他设置表示在 task.payload 中,并且 issue 中的 scope 使用问题已在所有脚本中得到解决时,即表示完成。
由索引模型根据 Issue 内容生成。
描述
Tl;dr, let's limit our usage of scopes to the restricted set, and determine non-restricted behavior/format/action based on task.payload.
Details:
Our usage of scopes came from the original funsize signingworker, which used scopes to determine the type of cert (dep/nightly/release), as well as the signing format (gpg/authenticode/dmg etc). With CoT, we restricted the cert scope, allowing for dep but restricting nightly and release to certain trees. Over time, we found that using scopes for formats was unwieldy, without seeing any benefit. We moved to specifying format in the task payload, and only setting the cert scope.
Let's continue this pattern throughout the scripts. Restricted scope types (e.g., balrog server, signing cert level, beetmover bucket) should continue to be scopes, and we should continue restricting them in scriptworker.constants.DEFAULT_CONFIG.cot_restricted_scopes. Any other scopes, we should deprecate, and move those settings into the task payload.
(To clarify: in the current proposal, all of cert:dep-signing, cert:nightly-signing, and cert:release-signing would each be scopes, even though only the latter 2 are restricted. We're just talking about removing the format scopes, for signing.)
Let's resolve this issue once all scripts follow this pattern.
- 主要语言
- Python
- 星标
- 16
- 派生
- 38
- 平均合并
- 1 天 7 小时
- 30 天内合并 PR
- 14
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
mozilla-releng/scriptworker-scripts 的其他 Issue
-
难度 5/5 一周以上 新手友好度 15/100
-
难度 5/5 一周以上 新手友好度 25/100
-
treescript
难度 5/5 一周以上 新手友好度 35/100
mozilla-releng/scriptworker-scripts#1055 · 2 条评论 ·
-
难度 4/5 3-5 天 新手友好度 32/100
mozilla-releng/scriptworker-scripts#994 · 1 条评论 ·
-
难度 4/5 3-5 天 新手友好度 35/100
mozilla-releng/scriptworker-scripts#980 · 1 条评论 ·
查看 mozilla-releng/scriptworker-scripts 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 75/100
-
hcocena 未关闭policies-accepted pre-review precheck-passed
难度 1/5 1 小时以内 新手友好度 88/100
Bioconductor/BiocContributions#214 · 5 条评论 ·
-
难度 1/5 1 小时以内 新手友好度 92/100
TencentCloud/Octop#1169 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
521xueweihan/HelloGitHub#3778 ·
-
The version checker's trailing attribute region has no control for a less-than inside a quoted value 未关闭area: dashboard area: tests bug perceived difficulty: 2 python
难度 2/5 1-3 小时 新手友好度 84/100
Nitjsefnie-Harness-Commons/daedalus#1105 · 1 条评论 ·