[rush] Operation Build Cache Log Restoration collision
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- typescript
- 领域
- build-system
调研方向
Start with libraries/rush-lib/src/logic/operations/OperationMetadataManager.ts at the linked location, then reproduce the collision by running the same cacheable operation with different parameters in parallel and rerunning the build. Compare the restored logs for each shard; done means each independent run restores its own logs rather than the logs from another shard.
由索引模型根据 Issue 内容生成。
描述
Summary
Operation Build Cache Log Restoration collision when multiple of same operation with different parameters run in parallel on same filesystem.
We are trying to run multiple of the same operation with different parameters on the same CI agent (for example, rush test:integration--shard=1 --shard-total=3, rush test:integration--shard=2 --shard-total=3, rush test:integration--shard=3 --shard-total=3). We do this to parallelize our tests and take advance of build caching.
This all works, but when restoring from cache, even despite the unique cache keys, the restored logs are all for one of the three shards.
Repro steps
- Have an operation with custom parameters on command-line, configured as build-cacheable
- Run multiple of that same operation, with different parameters passed on the same build agent in parallel
- Re run the build
Expected result:
Restored logs for each of the three independent runs
Actual result:
All three runs have restored logs for just one of the initially passing runs.
Details
I'm fairly certain the problem is here:
https://github.com/microsoft/rushstack/blob/main/libraries/rush-lib/src/logic/operations/OperationMetadataManager.ts#L66
The location on the filesystem is not unique per parameter, only per operation. (This despite the fact that the build cache is in fact parameter aware.
Standard questions
Please answer these questions to help us investigate your issue more quickly:
| Question | Answer |
|---|---|
@microsoft/rush globally installed version? |
5.155.0 |
rushVersion from rush.json? |
5.155.0 |
pnpmVersion, npmVersion, or yarnVersion from rush.json? |
[email protected] |
(if pnpm) useWorkspaces from pnpm-config.json? |
no |
| Operating system? | Linux |
| Would you consider contributing a PR? | Yes, but would need guidance, I don't see how to fix this |
Node.js version (node -v)? |
22.11.1 |
- 主要语言
- TypeScript
- 星标
- 6.5k
- 派生
- 708
- 平均合并
- 4 天 13 小时
- 30 天内合并 PR
- 62
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
microsoft/rushstack 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
-
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 2/5 1-3 小时 新手友好度 70/100
-
难度 4/5 3-5 天 新手友好度 45/100
查看 microsoft/rushstack 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 74/100
-
security
难度 2/5 1-3 小时 新手友好度 72/100
IBM/node-sdk-core#373 ·
-
e2e-failure ready-to-code
难度 2/5 1-3 小时 新手友好度 86/100
-
bug
难度 2/5 1-3 小时 新手友好度 74/100
-
chore
难度 2/5 1-3 小时 新手友好度 88/100