[rush] Operation Build Cache Log Restoration collision
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 35/100
- Type d'issue
- Bug
- Clarté
- Plutôt claire
- Activité
- À l'abandon
- Stack technique
- typescript
- Domaine
- build-system
Piste de recherche
Start with libraries/rush-lib/src/logic/operations/OperationMetadataManager.ts at the linked location, then reproduce the collision by running the same cacheable operation with different parameters in parallel and rerunning the build. Compare the restored logs for each shard; done means each independent run restores its own logs rather than the logs from another shard.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
Summary
Operation Build Cache Log Restoration collision when multiple of same operation with different parameters run in parallel on same filesystem.
We are trying to run multiple of the same operation with different parameters on the same CI agent (for example, rush test:integration--shard=1 --shard-total=3, rush test:integration--shard=2 --shard-total=3, rush test:integration--shard=3 --shard-total=3). We do this to parallelize our tests and take advance of build caching.
This all works, but when restoring from cache, even despite the unique cache keys, the restored logs are all for one of the three shards.
Repro steps
- Have an operation with custom parameters on command-line, configured as build-cacheable
- Run multiple of that same operation, with different parameters passed on the same build agent in parallel
- Re run the build
Expected result:
Restored logs for each of the three independent runs
Actual result:
All three runs have restored logs for just one of the initially passing runs.
Details
I'm fairly certain the problem is here:
https://github.com/microsoft/rushstack/blob/main/libraries/rush-lib/src/logic/operations/OperationMetadataManager.ts#L66
The location on the filesystem is not unique per parameter, only per operation. (This despite the fact that the build cache is in fact parameter aware.
Standard questions
Please answer these questions to help us investigate your issue more quickly:
| Question | Answer |
|---|---|
@microsoft/rush globally installed version? |
5.155.0 |
rushVersion from rush.json? |
5.155.0 |
pnpmVersion, npmVersion, or yarnVersion from rush.json? |
[email protected] |
(if pnpm) useWorkspaces from pnpm-config.json? |
no |
| Operating system? | Linux |
| Would you consider contributing a PR? | Yes, but would need guidance, I don't see how to fix this |
Node.js version (node -v)? |
22.11.1 |
- Langage dominant
- TypeScript
- Étoiles
- 6.5k
- Forks
- 708
- Merge moyen
- 4 j 13 h
- PR mergées (30 j)
- 62
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de microsoft/rushstack
-
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
-
Difficulté 2/5 1-3 heures Accessibilité débutants 65/100
-
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
-
Difficulté 2/5 1-3 heures Accessibilité débutants 70/100
-
Difficulté 4/5 3-5 jours Accessibilité débutants 45/100
Toutes les issues de microsoft/rushstack
Issues similaires
-
Difficulté 1/5 1-3 heures Accessibilité débutants 88/100
motiondivision/motion#3849 ·
-
Add: S Play Event HD Ouvertecheck:passed streams:add
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
-
Improvement for contact popover Ouverte
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
-
LiteLLM proxy response_cost (x-litellm-response-cost) is never applied to ChatModelOutput.cost Ouvertebug
Difficulté 2/5 1-3 heures Accessibilité débutants 84/100
i-am-bee/beeai-framework#1697 · 1 réaction ·
-
Support bun dedupe Ouverteenhancement
Difficulté 2/5 1-3 heures Accessibilité débutants 75/100
antfu/node-modules-inspector#214 ·