fix(source-control): review evidence rejects completion records ending in account=fallback
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 85/100
调研方向
阅读 plugins/source-control/skills/babysit-prs/scripts/babysit_review_evidence.py 中 RECORD_RE 和 _record 附近的内容，然后检查 scripts/tests/test_babysit_review_evidence.py 中相关的用例。为以 account=fallback 结尾的完整记录和增量记录添加覆盖，并添加一个末尾文本格式错误的用例。完成标准是：fallback 后缀与相同的证据字段绑定，而其他末尾文本仍会被拒绝。
由索引模型根据 Issue 内容生成。
描述
Problem
RECORD_RE in plugins/source-control/skills/babysit-prs/scripts/babysit_review_evidence.py (lines 55-61) anchors the completion record at $ right after scope=whole or scope=incremental since=<sha>. The lane producer adds account=fallback to the end of that record whenever the review ran on the fallback account. See melodic-software/ci-workflows .github/workflows/pr-review.yml lines 1179-1213 (read at d61aeac):
if [ "$ACCOUNT" = fallback ]; then
account=" account=fallback"
...
echo "::notice title=claude-lane-review-complete::$record findings=$FINDINGS inline=$INLINE $scope$account"
_record rejects that record as record-malformed. So a lane whose covering review, or any link in its incremental chain, was reviewed on the fallback account never binds.
Risk
The gate fails closed, so nothing merges that should not. The cost is that it stays stuck: every pull request whose review fell back to the second account after a usage limit cannot reach pr-merge until a new review runs on the primary account. Priority is low because the gate stays safe and only throughput is lost.
Fix
Accept an optional trailing account=fallback (and only that token) after the findings=… scope=… form in RECORD_RE. Treat the record exactly like a primary-account record. The skip forms carry no account suffix in the producer, so leave them unchanged.
Done when
- A record ending in
account=fallbackbinds with the same findings, inline and scope as the same record without the suffix. - Any other trailing text is still
record-malformed, and a test covers it. - Tests in
scripts/tests/test_babysit_review_evidence.pycover the whole and incremental forms with the suffix, and fail before the fix.
needs-human: this changes what the unattended merge gate accepts as review evidence, so a human reviews and merges it.
- 主要语言
- Shell
- 星标
- 22
- 派生
- 2
- 平均合并
- 8 小时 44 分钟
- 30 天内合并 PR
- 926
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
melodic-software/claude-code-plugins 的其他 Issue
-
status: ready
难度 2/5 1-3 小时 新手友好度 73/100
melodic-software/claude-code-plugins#8537 ·
维护者通常 1 天内回复
-
priority: medium status: confirmed
难度 2/5 1-3 小时 新手友好度 72/100
melodic-software/claude-code-plugins#8507 · 1 条评论 ·
维护者通常 1 天内回复
-
priority: low
难度 2/5 1-3 小时 新手友好度 82/100
melodic-software/claude-code-plugins#8476 · 1 条评论 ·
维护者通常 1 天内回复
-
area: security needs-human priority: low
难度 2/5 1-3 小时 新手友好度 68/100
melodic-software/claude-code-plugins#8472 · 1 条评论 ·
维护者通常 1 天内回复
-
priority: low
难度 2/5 1-3 小时 新手友好度 72/100
melodic-software/claude-code-plugins#8434 · 1 条评论 ·
维护者通常 1 天内回复
查看 melodic-software/claude-code-plugins 的全部 Issue
相似的 Issue
-
Gemini: respect PLANNING_DISABLED=1 in lifecycle context hooks可能已有人在做 @AmariAugustin 今天认领。 未关闭bug good first issue help wanted
难度 2/5 1-3 小时 新手友好度 87/100
OthmanAdi/planning-with-files#329 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 2 天内回复
-
headers-parser: `forRegExp` does not escape regexp characters in path segments that contain `*`可能已有人在做 @RaphaelFakhri 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复
-
needs-triage
难度 2/5 1-3 小时 新手友好度 82/100
mattpocock/skills#1307 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 84/100
vladmandic/sdnext#5161 ·
维护者通常 1 天内回复