Recurring review comments: 3 proposed changes

维护者通常 1 天内回复

评估

调研方向

描述

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Reviewers keep making these points on PRs to this repo, each on 3+ PRs by 2+ authors in the last 90 days. Each proposes an AGENTS.md line or a lint rule that would have prevented them.

Acceptance criteria

Each change is made, or declined in a comment here.

• Tests assert outcomes through translator references and roles, not literals, internals or presence
• Prefer lodash and existing utilities over hand-rolled helpers
• Accessible names, live regions and focus follow ARIA/WCAG patterns

Proposed changes

Tests assert outcomes through translator references and roles, not literals, internals or presence (5 PRs, 3 authors)

AGENTS.md Testing: "Assert the resulting state, such as document HTML, the role-scoped text (getByRole('status')), or saved DB rows equal to the input, not call chains, fetch strategy or toBeInTheDocument() presence. Reference strings through their translator (tr.$tr(...)/str$()), never literals. Never query KDS/keen-ui internal classes; use within(getByTestId(...))."

• https://github.com/learningequality/studio/pull/6132#discussion_r4145386225 (#6132, contentcuration/contentcuration/frontend/channelList/views/Channel/StudioMyChannels/__tests__/StudioMyChannels.spec.js)
• https://github.com/learningequality/studio/pull/6113#discussion_r4019744533 (#6113, contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/associate/__tests__/Editor.spec.js)
• https://github.com/learningequality/studio/pull/6310#discussion_r4230889920 (#6310, contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/choice/__tests__/Editor.spec.js)
• https://github.com/learningequality/studio/pull/6132#discussion_r4019161806 (#6132, contentcuration/contentcuration/frontend/channelList/views/Channel/StudioMyChannels/__tests__/StudioMyChannels.spec.js)
• https://github.com/learningequality/studio/pull/6280#discussion_r4170638651 (#6280, contentcuration/contentcuration/frontend/shared/views/TipTapEditor/__tests__/EditorToolbar.spec.js)
• https://github.com/learningequality/studio/pull/6132#discussion_r4019161813 (#6132, contentcuration/contentcuration/frontend/channelList/views/Organization/__tests__/OrganizationPages.spec.js)
• https://github.com/learningequality/studio/pull/6243#discussion_r4186927393 (#6243, contentcuration/contentcuration/tests/test_restore_channel.py)
• https://github.com/learningequality/studio/pull/6243#discussion_r4167795884 (#6243, contentcuration/contentcuration/tests/test_restore_channel.py)

Prefer lodash and existing utilities over hand-rolled helpers (3 PRs, 2 authors)

AGENTS.md Code: "Before writing a helper, use lodash (lodash/shuffle, lodash/flatMap), existing composables (shared/composables/useFetch), or a maintained library (@internationalized/number for locale numbers)."

• https://github.com/learningequality/studio/pull/6113#discussion_r3904927004 (#6113, contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/associate/AssociateInteractionEditor.vue)
• https://github.com/learningequality/studio/pull/6113#discussion_r3904821186 (#6113, contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/associate/parse.js)
• https://github.com/learningequality/studio/pull/6132#discussion_r4019161769 (#6132, contentcuration/contentcuration/frontend/channelList/composables/useOrganizations.js)
• https://github.com/learningequality/studio/pull/6282#discussion_r4212626845 (#6282, contentcuration/contentcuration/frontend/shared/views/QTIEditor/utils/localeNumbers.js)

Accessible names, live regions and focus follow ARIA/WCAG patterns (6 PRs, 3 authors)

AGENTS.md a11y: "Live regions (role="status"/aria-live) stay mounted empty and only their text changes, with one writer per region. Key sibling v-ifs. Never unmount the focused control. Use KDS widgets (KDropdownMenu, KTabsPanel, KCard :to) for their ARIA wiring. Accessible names start with the visible text. Focus stays visible on every state." Lint: vuejs-accessibility plugin.

• https://github.com/learningequality/studio/pull/6310#discussion_r4230889915 (#6310, contentcuration/contentcuration/frontend/shared/views/QTIEditor/components/ValidationMessage/index.vue)
• https://github.com/learningequality/studio/pull/6310#discussion_r4231445325 (#6310, contentcuration/contentcuration/frontend/shared/views/QTIEditor/components/ValidationMessage/index.vue)
• https://github.com/learningequality/studio/pull/6310#discussion_r4232217377 (#6310, contentcuration/contentcuration/frontend/shared/views/QTIEditor/components/ValidationMessage/index.vue)
• https://github.com/learningequality/studio/pull/6310#discussion_r4231445337 (#6310, contentcuration/contentcuration/frontend/shared/views/QTIEditor/components/ValidationMessage/index.vue)
• https://github.com/learningequality/studio/pull/6132#discussion_r4019161797 (#6132, contentcuration/contentcuration/frontend/channelList/views/Organization/NewOrganization.vue)
• https://github.com/learningequality/studio/pull/6132#discussion_r4140381097 (#6132, contentcuration/contentcuration/frontend/channelList/composables/useChannelOrganizationFilter.js)
• https://github.com/learningequality/studio/pull/6280#discussion_r4170067156 (#6280, contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/FormatDropdown.vue)
• https://github.com/learningequality/studio/pull/6280#discussion_r4170067131 (#6280, contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/FormatDropdown.vue)
• https://github.com/learningequality/studio/pull/6132#discussion_r4019161744 (#6132, contentcuration/contentcuration/frontend/channelList/views/Organization/OrganizationDetails.vue)
• https://github.com/learningequality/studio/pull/6132#discussion_r4019161784 (#6132, contentcuration/contentcuration/frontend/channelList/views/Organization/OrganizationCard.vue)
• https://github.com/learningequality/studio/pull/6108#discussion_r3903946338 (#6108, contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/MobileTopBar.vue)
• https://github.com/learningequality/studio/pull/6317#discussion_r4265162041 (#6317, contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/choice/Editor.vue)
• https://github.com/learningequality/studio/pull/6277#discussion_r4199173419 (#6277, contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/inlineChoice/components/InlineChoiceChip/index.vue)

环境准备

从这里开始

1. 先读完整个 Issue，再读项目的贡献指南。
2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
3. Fork 仓库，在一个分支上完成修改。
4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

learningequality/studio 的其他 Issue

• Set unpublishable: true on PublishedChange by construction to simplify handleMaxRevs predicate

  未关闭

  ⋯反馈这个 Issue 的问题

  • 哪里不对？

  • 已被占
  • 不适合新手
  • 已失效
  • 其他…
  • 发送 取消
  DEV: frontend P3 - low

  难度 2/5 1-3 小时 新手友好度 74/100

  learningequality/studio#5868 · 2026年4月29日 创建

  维护者通常 1 天内回复

• Change ricecooker version checks to hard warning only

  未关闭

  ⋯反馈这个 Issue 的问题

  • 哪里不对？

  • 已被占
  • 不适合新手
  • 已失效
  • 其他…
  • 发送 取消
  TAG: tech update / debt

  难度 2/5 1-3 小时 新手友好度 62/100

  learningequality/studio#2245 · 2020年9月10日 创建

  维护者通常 1 天内回复

• [QTI] Match question - Cannot close match row editor, save initial match chip, or delete single match

  未关闭

  ⋯反馈这个 Issue 的问题

  • 哪里不对？

  • 已被占
  • 不适合新手
  • 已失效
  • 其他…
  • 发送 取消
  bug

  难度 3/5 1-2 天 新手友好度 25/100

  learningequality/studio#6326 · 1 条评论 · 2026年10月21日 创建

  维护者通常 1 天内回复

• [QTI] - 'Response type' drop-down issues

  未关闭

  ⋯反馈这个 Issue 的问题

  • 哪里不对？

  • 已被占
  • 不适合新手
  • 已失效
  • 其他…
  • 发送 取消
  bug

  难度 2/5 1-3 小时 新手友好度 15/100

  learningequality/studio#6325 · 1 条评论 · 2026年10月21日 创建

  维护者通常 1 天内回复

• [QTI] Match question: Reused target options appear as duplicates in Studio response pool

  未关闭

  ⋯反馈这个 Issue 的问题

  • 哪里不对？

  • 已被占
  • 不适合新手
  • 已失效
  • 其他…
  • 发送 取消
  bug

  难度 3/5 1-2 天 新手友好度 35/100

  learningequality/studio#6324 · 1 条评论 · 1 个 reaction · 2026年10月21日 创建

  维护者通常 1 天内回复

查看 learningequality/studio 的全部 Issue

相似的 Issue

• [oblt-aw][autodoc] Update workflow docs for gh-aw v0.92.5 and detector permission scope

  可能已有人在做 @github-actions 今天认领。 未关闭

  ⋯反馈这个 Issue 的问题

  • 哪里不对？

  • 已被占
  • 不适合新手
  • 已失效
  • 其他…
  • 发送 取消

  难度 1/5 1-3 小时 新手友好度 88/100

  elastic/oblt-aw#2442 · 2026年10月23日 创建

  维护者通常 1 天内回复

• The rose-suite.conf file copied to output webpage does not contain any opt settings

  未关闭

  ⋯反馈这个 Issue 的问题

  • 哪里不对？

  • 已被占
  • 不适合新手
  • 已失效
  • 其他…
  • 发送 取消
  enhancement

  难度 2/5 1-3 小时 新手友好度 82/100

  MetOffice/CSET#2542 · 2026年10月23日 创建

  维护者通常 1 天内回复

• feat(ide): VS Code access through the shipped MCP server (config doc and tool-list smoke test)

  未关闭

  ⋯反馈这个 Issue 的问题

  • 哪里不对？

  • 已被占
  • 不适合新手
  • 已失效
  • 其他…
  • 发送 取消
  roadmap-100

  难度 2/5 1-3 小时 新手友好度 82/100

  asklokesh/loki-mode#392 · 2026年10月23日 创建

  维护者通常 1 天内回复

• browser_cdp: transient /json/version discovery failure is reported as "CDP endpoint is not a WebSocket URL"

  未关闭

  ⋯反馈这个 Issue 的问题

  • 哪里不对？

  • 已被占
  • 不适合新手
  • 已失效
  • 其他…
  • 发送 取消
  comp/tools P2 tool/browser tool/file type/bug

  难度 2/5 1-3 小时 新手友好度 75/100

  NousResearch/hermes-agent#143418 · 1 条评论 · 2026年10月23日 创建

  维护者通常 1 天内回复

• An empty list or mapping is expanded as a defined value: `{x,v}` with `v=[]` gives `1,`, `{#v}` gives `#`, `{;v}` gives `;v=`

  未关闭

  ⋯反馈这个 Issue 的问题

  • 哪里不对？

  • 已被占
  • 不适合新手
  • 已失效
  • 其他…
  • 发送 取消

  难度 2/5 1-3 小时 新手友好度 78/100

  python-hyper/uritemplate#164 · 2026年10月23日 创建

更多 Python Issue