Recurring review comments: 3 proposed changes
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 25/100
- Tipo di issue
- Documentazione
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- javascript, markdown
Direzione di ricerca
Read AGENTS.md and inspect the project’s lint configuration before deciding whether to add each proposed guideline or vuejs-accessibility rule. Use the linked files as examples, especially the QTI editor and TipTap editor tests/components. Done means each of the three proposals is implemented or explicitly declined in a comment, but this issue is marked not open for contribution.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.
Reviewers keep making these points on PRs to this repo, each on 3+ PRs by 2+ authors in the last 90 days. Each proposes an AGENTS.md line or a lint rule that would have prevented them.
Acceptance criteria
Each change is made, or declined in a comment here.
- Tests assert outcomes through translator references and roles, not literals, internals or presence
- Prefer lodash and existing utilities over hand-rolled helpers
- Accessible names, live regions and focus follow ARIA/WCAG patterns
Proposed changes
Tests assert outcomes through translator references and roles, not literals, internals or presence (5 PRs, 3 authors)
AGENTS.md Testing: "Assert the resulting state, such as document HTML, the role-scoped text (getByRole('status')), or saved DB rows equal to the input, not call chains, fetch strategy or toBeInTheDocument() presence. Reference strings through their translator (tr.$tr(...)/str$()), never literals. Never query KDS/keen-ui internal classes; use within(getByTestId(...))."
- https://github.com/learningequality/studio/pull/6132#discussion_r4145386225 (#6132,
contentcuration/contentcuration/frontend/channelList/views/Channel/StudioMyChannels/__tests__/StudioMyChannels.spec.js) - https://github.com/learningequality/studio/pull/6113#discussion_r4019744533 (#6113,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/associate/__tests__/Editor.spec.js) - https://github.com/learningequality/studio/pull/6310#discussion_r4230889920 (#6310,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/choice/__tests__/Editor.spec.js) - https://github.com/learningequality/studio/pull/6132#discussion_r4019161806 (#6132,
contentcuration/contentcuration/frontend/channelList/views/Channel/StudioMyChannels/__tests__/StudioMyChannels.spec.js) - https://github.com/learningequality/studio/pull/6280#discussion_r4170638651 (#6280,
contentcuration/contentcuration/frontend/shared/views/TipTapEditor/__tests__/EditorToolbar.spec.js) - https://github.com/learningequality/studio/pull/6132#discussion_r4019161813 (#6132,
contentcuration/contentcuration/frontend/channelList/views/Organization/__tests__/OrganizationPages.spec.js) - https://github.com/learningequality/studio/pull/6243#discussion_r4186927393 (#6243,
contentcuration/contentcuration/tests/test_restore_channel.py) - https://github.com/learningequality/studio/pull/6243#discussion_r4167795884 (#6243,
contentcuration/contentcuration/tests/test_restore_channel.py)
Prefer lodash and existing utilities over hand-rolled helpers (3 PRs, 2 authors)
AGENTS.md Code: "Before writing a helper, use lodash (lodash/shuffle, lodash/flatMap), existing composables (shared/composables/useFetch), or a maintained library (@internationalized/number for locale numbers)."
- https://github.com/learningequality/studio/pull/6113#discussion_r3904927004 (#6113,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/associate/AssociateInteractionEditor.vue) - https://github.com/learningequality/studio/pull/6113#discussion_r3904821186 (#6113,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/associate/parse.js) - https://github.com/learningequality/studio/pull/6132#discussion_r4019161769 (#6132,
contentcuration/contentcuration/frontend/channelList/composables/useOrganizations.js) - https://github.com/learningequality/studio/pull/6282#discussion_r4212626845 (#6282,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/utils/localeNumbers.js)
Accessible names, live regions and focus follow ARIA/WCAG patterns (6 PRs, 3 authors)
AGENTS.md a11y: "Live regions (role="status"/aria-live) stay mounted empty and only their text changes, with one writer per region. Key sibling v-ifs. Never unmount the focused control. Use KDS widgets (KDropdownMenu, KTabsPanel, KCard :to) for their ARIA wiring. Accessible names start with the visible text. Focus stays visible on every state." Lint: vuejs-accessibility plugin.
- https://github.com/learningequality/studio/pull/6310#discussion_r4230889915 (#6310,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/components/ValidationMessage/index.vue) - https://github.com/learningequality/studio/pull/6310#discussion_r4231445325 (#6310,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/components/ValidationMessage/index.vue) - https://github.com/learningequality/studio/pull/6310#discussion_r4232217377 (#6310,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/components/ValidationMessage/index.vue) - https://github.com/learningequality/studio/pull/6310#discussion_r4231445337 (#6310,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/components/ValidationMessage/index.vue) - https://github.com/learningequality/studio/pull/6132#discussion_r4019161797 (#6132,
contentcuration/contentcuration/frontend/channelList/views/Organization/NewOrganization.vue) - https://github.com/learningequality/studio/pull/6132#discussion_r4140381097 (#6132,
contentcuration/contentcuration/frontend/channelList/composables/useChannelOrganizationFilter.js) - https://github.com/learningequality/studio/pull/6280#discussion_r4170067156 (#6280,
contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/FormatDropdown.vue) - https://github.com/learningequality/studio/pull/6280#discussion_r4170067131 (#6280,
contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/FormatDropdown.vue) - https://github.com/learningequality/studio/pull/6132#discussion_r4019161744 (#6132,
contentcuration/contentcuration/frontend/channelList/views/Organization/OrganizationDetails.vue) - https://github.com/learningequality/studio/pull/6132#discussion_r4019161784 (#6132,
contentcuration/contentcuration/frontend/channelList/views/Organization/OrganizationCard.vue) - https://github.com/learningequality/studio/pull/6108#discussion_r3903946338 (#6108,
contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/MobileTopBar.vue) - https://github.com/learningequality/studio/pull/6317#discussion_r4265162041 (#6317,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/choice/Editor.vue) - https://github.com/learningequality/studio/pull/6277#discussion_r4199173419 (#6277,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/inlineChoice/components/InlineChoiceChip/index.vue)
- Lingua principale
- Python
- Stelle
- 213
- Fork
- 314
- Merge medio
- 2g 17h
- PR unite (30g)
- 68
Preparare l'ambiente
- Include un Dockerfile o un file Docker Compose
- Nessun modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di learningequality/studio
-
Set unpublishable: true on PublishedChange by construction to simplify handleMaxRevs predicateApertaDEV: frontend P3 - low
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
learningequality/studio#5868 ·
I maintainer di solito rispondono entro 1 giorno
-
TAG: tech update / debt
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
learningequality/studio#2245 ·
I maintainer di solito rispondono entro 1 giorno
-
bug DEV: frontend P1 - important
Difficoltà 2/5 1-3 ore Idoneità per principianti 25/100
learningequality/studio#6322 · 1 reazione ·
I maintainer di solito rispondono entro 1 giorno
-
TAG: tech update / debt
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
learningequality/studio#6318 ·
I maintainer di solito rispondono entro 1 giorno
-
bug DEV: frontend P0 - critical
Difficoltà 3/5 1-2 giorni Idoneità per principianti 22/100
learningequality/studio#6316 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di learningequality/studio
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
-
changelog investigate
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
ramnes/notion-sdk-py#423 ·
-
type-bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 77/100
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno