Recurring review comments: 3 proposed changes
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 25/100
- Tipo de issue
- Documentación
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- javascript, markdown
Línea de trabajo
Read AGENTS.md and inspect the project’s lint configuration before deciding whether to add each proposed guideline or vuejs-accessibility rule. Use the linked files as examples, especially the QTI editor and TipTap editor tests/components. Done means each of the three proposals is implemented or explicitly declined in a comment, but this issue is marked not open for contribution.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.
Reviewers keep making these points on PRs to this repo, each on 3+ PRs by 2+ authors in the last 90 days. Each proposes an AGENTS.md line or a lint rule that would have prevented them.
Acceptance criteria
Each change is made, or declined in a comment here.
- Tests assert outcomes through translator references and roles, not literals, internals or presence
- Prefer lodash and existing utilities over hand-rolled helpers
- Accessible names, live regions and focus follow ARIA/WCAG patterns
Proposed changes
Tests assert outcomes through translator references and roles, not literals, internals or presence (5 PRs, 3 authors)
AGENTS.md Testing: "Assert the resulting state, such as document HTML, the role-scoped text (getByRole('status')), or saved DB rows equal to the input, not call chains, fetch strategy or toBeInTheDocument() presence. Reference strings through their translator (tr.$tr(...)/str$()), never literals. Never query KDS/keen-ui internal classes; use within(getByTestId(...))."
- https://github.com/learningequality/studio/pull/6132#discussion_r4145386225 (#6132,
contentcuration/contentcuration/frontend/channelList/views/Channel/StudioMyChannels/__tests__/StudioMyChannels.spec.js) - https://github.com/learningequality/studio/pull/6113#discussion_r4019744533 (#6113,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/associate/__tests__/Editor.spec.js) - https://github.com/learningequality/studio/pull/6310#discussion_r4230889920 (#6310,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/choice/__tests__/Editor.spec.js) - https://github.com/learningequality/studio/pull/6132#discussion_r4019161806 (#6132,
contentcuration/contentcuration/frontend/channelList/views/Channel/StudioMyChannels/__tests__/StudioMyChannels.spec.js) - https://github.com/learningequality/studio/pull/6280#discussion_r4170638651 (#6280,
contentcuration/contentcuration/frontend/shared/views/TipTapEditor/__tests__/EditorToolbar.spec.js) - https://github.com/learningequality/studio/pull/6132#discussion_r4019161813 (#6132,
contentcuration/contentcuration/frontend/channelList/views/Organization/__tests__/OrganizationPages.spec.js) - https://github.com/learningequality/studio/pull/6243#discussion_r4186927393 (#6243,
contentcuration/contentcuration/tests/test_restore_channel.py) - https://github.com/learningequality/studio/pull/6243#discussion_r4167795884 (#6243,
contentcuration/contentcuration/tests/test_restore_channel.py)
Prefer lodash and existing utilities over hand-rolled helpers (3 PRs, 2 authors)
AGENTS.md Code: "Before writing a helper, use lodash (lodash/shuffle, lodash/flatMap), existing composables (shared/composables/useFetch), or a maintained library (@internationalized/number for locale numbers)."
- https://github.com/learningequality/studio/pull/6113#discussion_r3904927004 (#6113,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/associate/AssociateInteractionEditor.vue) - https://github.com/learningequality/studio/pull/6113#discussion_r3904821186 (#6113,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/associate/parse.js) - https://github.com/learningequality/studio/pull/6132#discussion_r4019161769 (#6132,
contentcuration/contentcuration/frontend/channelList/composables/useOrganizations.js) - https://github.com/learningequality/studio/pull/6282#discussion_r4212626845 (#6282,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/utils/localeNumbers.js)
Accessible names, live regions and focus follow ARIA/WCAG patterns (6 PRs, 3 authors)
AGENTS.md a11y: "Live regions (role="status"/aria-live) stay mounted empty and only their text changes, with one writer per region. Key sibling v-ifs. Never unmount the focused control. Use KDS widgets (KDropdownMenu, KTabsPanel, KCard :to) for their ARIA wiring. Accessible names start with the visible text. Focus stays visible on every state." Lint: vuejs-accessibility plugin.
- https://github.com/learningequality/studio/pull/6310#discussion_r4230889915 (#6310,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/components/ValidationMessage/index.vue) - https://github.com/learningequality/studio/pull/6310#discussion_r4231445325 (#6310,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/components/ValidationMessage/index.vue) - https://github.com/learningequality/studio/pull/6310#discussion_r4232217377 (#6310,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/components/ValidationMessage/index.vue) - https://github.com/learningequality/studio/pull/6310#discussion_r4231445337 (#6310,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/components/ValidationMessage/index.vue) - https://github.com/learningequality/studio/pull/6132#discussion_r4019161797 (#6132,
contentcuration/contentcuration/frontend/channelList/views/Organization/NewOrganization.vue) - https://github.com/learningequality/studio/pull/6132#discussion_r4140381097 (#6132,
contentcuration/contentcuration/frontend/channelList/composables/useChannelOrganizationFilter.js) - https://github.com/learningequality/studio/pull/6280#discussion_r4170067156 (#6280,
contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/FormatDropdown.vue) - https://github.com/learningequality/studio/pull/6280#discussion_r4170067131 (#6280,
contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/FormatDropdown.vue) - https://github.com/learningequality/studio/pull/6132#discussion_r4019161744 (#6132,
contentcuration/contentcuration/frontend/channelList/views/Organization/OrganizationDetails.vue) - https://github.com/learningequality/studio/pull/6132#discussion_r4019161784 (#6132,
contentcuration/contentcuration/frontend/channelList/views/Organization/OrganizationCard.vue) - https://github.com/learningequality/studio/pull/6108#discussion_r3903946338 (#6108,
contentcuration/contentcuration/frontend/shared/views/TipTapEditor/TipTapEditor/components/toolbar/MobileTopBar.vue) - https://github.com/learningequality/studio/pull/6317#discussion_r4265162041 (#6317,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/choice/Editor.vue) - https://github.com/learningequality/studio/pull/6277#discussion_r4199173419 (#6277,
contentcuration/contentcuration/frontend/shared/views/QTIEditor/interactions/inlineChoice/components/InlineChoiceChip/index.vue)
- Lenguaje dominante
- Python
- Estrellas
- 213
- Forks
- 314
- Merge medio
- 2 d 17 h
- PR fusionados (30 d)
- 68
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de learningequality/studio
-
Set unpublishable: true on PublishedChange by construction to simplify handleMaxRevs predicateAbiertoDEV: frontend P3 - low
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
learningequality/studio#5868 ·
Los mantenedores suelen responder en 1 día
-
TAG: tech update / debt
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
learningequality/studio#2245 ·
Los mantenedores suelen responder en 1 día
-
TAG: tech update / debt
Dificultad 4/5 3-5 días Aptitud para principiantes 35/100
learningequality/studio#6318 ·
Los mantenedores suelen responder en 1 día
-
bug DEV: frontend P0 - critical
Dificultad 3/5 1-2 días Aptitud para principiantes 22/100
learningequality/studio#6316 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 4/5 1-2 días Aptitud para principiantes 35/100
learningequality/studio#6315 · 1 comentario ·
Los mantenedores suelen responder en 1 día
Todos los issues de learningequality/studio
Issues similares
-
get_page_thumbnail modifies cached page images, affecting later thumbnails and picture exportsAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
docling-project/docling-mcp#147 ·
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
autowarefoundation/autoware_carla_scenario#405 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 79/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
mohitmishra786/readprism#322 ·
Los mantenedores suelen responder en 1 día