[Refactor/Chore] Preserve the Amplitude lazy-loading boundary in tracking utilities

未关闭
#42,439 1 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
55/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
活跃
技术栈
typescript

调研方向

Start by building the Vinext browser target and inspecting the client manifest’s static imports. Trace web/app/components/base/amplitude/lazy-amplitude-provider.tsx, amplitude/index.ts, utils.ts, init.ts, app/components/main-nav/layout.tsx, and CloudAnalyticsLayoutBoundary. Done means the SDK implementation is not statically pulled in by lightweight consumers, while consent, initialization, identity, opt-out, registration flushing, and synchronization behavior remain intact; compare build graphs and transferred JavaScript.

由索引模型根据 Issue 内容生成。

描述

project#dify
Self Checks
  • I have read the Contributing Guide and Language Policy.
  • This is only for refactors or chores; if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report, otherwise it will be closed.
  • 【中文用户 & Non English User】请使用英语提交,否则会被关闭 :)
  • Please do not modify this template :) and fill in all the required fields.
Description

Keep Amplitude SDK implementation imports behind the analytics activation boundary. The provider is dynamically imported, but common tracking utilities bypass that boundary through static imports:

  1. web/app/components/base/amplitude/lazy-amplitude-provider.tsx dynamically imports AmplitudeProvider.
  2. amplitude/index.ts also re-exports tracking and identity functions from utils.ts.
  3. utils.ts statically imports @amplitude/analytics-browser and getIsAmplitudeInitialized from ./init.
  4. init.ts statically imports both @amplitude/analytics-browser and @amplitude/plugin-session-replay-browser.
  5. Navigation/account UI and external-service synchronization use these utilities.

A local Rolldown client build confirms the static manifest chain:

app/components/main-nav/layout.tsx
  → _help-menu-D6_0F4Dx.js
  → _utils-UCOVMtae.js

CloudAnalyticsLayoutBoundary also statically imports the utils chunk. That shared chunk contains 187 modules and is 337,689 bytes, approximately 92,891 bytes gzip. These are shared-chunk sizes, not guaranteed savings or measured production network transfer. Several replay recording modules remain dynamic imports; their entire package sizes should not be counted as eager payload.

Reproduce by building the Vinext browser target, inspecting the client manifest's static imports, and tracing the utilities above. The provider's dynamic import alone does not prevent the SDK from being reached statically elsewhere.

Motivation

Checking consent or API-key availability before SDK calls does not defer static imports. This is a loading/performance issue, not evidence of analytics events being sent before consent.

Suggested direction: keep initialization status and listeners in a lightweight module, and lazily load the SDK implementation only when analytics is eligible to activate. Audit utility/barrel imports so they do not reintroduce an eager path.

Acceptance criteria:

  • Verify production requests with consent denied, analytics disabled/no API key, and consent granted.
  • Ensure lightweight tracking/status consumers do not statically pull in the SDK initialization implementation.
  • Preserve registration-event flushing, identity synchronization, initialization notification, opt-out behavior, and consent transitions.
  • Compare before/after build graphs and transferred JS; do not claim the entire shared chunk as savings without measurement.
Additional Context

Measured on a local Dify 1.17.1 development branch based on 06e473015a9a1abb71da88ac0a0e92d96a992008, with local DevTools integration patches, using Vinext 1.0.0-beta.10, Vite+ core 0.3.2, and Node 24.21.0. Browser analysis session: sid_4_1789651325793 (12,219 modules). Recheck against current main when implementing.

Related closed work: #33887 discussed lazy initializers and dev cold-load performance; #38514 separated bootstrap/external-service responsibilities. This report specifically tracks the remaining static SDK path in production build output.

主要语言
TypeScript
星标
157k
派生
24.7k
平均合并
22 小时 32 分钟
30 天内合并 PR
611

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

langgenius/dify 的其他 Issue

查看 langgenius/dify 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。